940299 - Add a runtime suppression file for ThreadSanitizer

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Holler (:decoder)]

ThreadSanitizer does not only support compile-time blacklisting but also a runtime suppression list. That list is more expensive to use, but in some cases it's the better (and only) way to properly suppress a bug still being fixed or false positive.

I'll attach a patch in a few that adds the file at build/sanitizers/tsan_suppressions.txt and includes all suppressions for bugs that are already on file, including their bug numbers.

Comment 1

[Christian Holler (:decoder)]

Attachment: tsan-supp.patch

Glandium, I initially discussed this with ted, but he seems to be swamped with review requests. Can you review this simple thing? It's just a file being added to the tree for TSan.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8334449 [details] [diff] [review]
tsan-supp.patch

Review of attachment 8334449 [details] [diff] [review]:
-----------------------------------------------------------------

What's supposed to happen to this file?

Comment 3

[Christian Holler (:decoder)]

(In reply to Mike Hommey [:glandium] from comment #2)
> 
> What's supposed to happen to this file?

The file is used at runtime by setting TSAN_OPTIONS="suppressions=...". It's a runtime suppression file just like Valgrind suppressions (see also http://code.google.com/p/thread-sanitizer/wiki/Suppressions ).

Right now, this is supposed to be used manually when running TSan, to suppress all the bugs we have on file already (and false positives), so we can get TSan usable. In the future, this file might be used as well in automation when running our tests, but that's a different bug then.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8334449 [details] [diff] [review]
tsan-supp.patch

Review of attachment 8334449 [details] [diff] [review]:
-----------------------------------------------------------------

What's supposed to happen to this file?

Comment 5

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12c3d72de02e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12c3d72de02e