Move the noScriptRval flag from CompartmentOptions to RuntimeOptions

RESOLVED FIXED in mozilla34

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ejpbruel, Assigned: Bobby Holley (On Leave Until June 11th))

Tracking

(Blocks: 1 bug)

unspecified
mozilla34
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Depends on: 939562
Eddy, I seem to recall that you had (potentially-orange) patches for these? If you upload them, I can take a crack at getting them green.
Flags: needinfo?(ejpbruel)
(Reporter)

Comment 2

4 years ago
(In reply to Bobby Holley (:bholley) from comment #1)
> Eddy, I seem to recall that you had (potentially-orange) patches for these?
> If you upload them, I can take a crack at getting them green.

I believe I had some patches for this, yes, but I can't seem to find them on my machine anymore. I may have accidentally deleted them at some point :-(
Flags: needinfo?(ejpbruel)
Created attachment 8464801 [details] [diff] [review]
Eliminate ambient noScriptRval, and make it live exclusively on CompileOptions. v1
Attachment #8464801 - Flags: review?(jdemooij)
Comment on attachment 8464801 [details] [diff] [review]
Eliminate ambient noScriptRval, and make it live exclusively on CompileOptions. v1

Review of attachment 8464801 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, only 3 cx flags left :)
Attachment #8464801 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/3069d118d21d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.