Closed Bug 940321 Opened 6 years ago Closed 5 years ago

Move the noScriptRval flag from CompartmentOptions to RuntimeOptions

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: ejpbruel, Assigned: bholley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Depends on: 939562
Eddy, I seem to recall that you had (potentially-orange) patches for these? If you upload them, I can take a crack at getting them green.
Flags: needinfo?(ejpbruel)
(In reply to Bobby Holley (:bholley) from comment #1)
> Eddy, I seem to recall that you had (potentially-orange) patches for these?
> If you upload them, I can take a crack at getting them green.

I believe I had some patches for this, yes, but I can't seem to find them on my machine anymore. I may have accidentally deleted them at some point :-(
Flags: needinfo?(ejpbruel)
https://tbpl.mozilla.org/?tree=Try&rev=1c968d9e9a1f
Assignee: nobody → bobbyholley
Comment on attachment 8464801 [details] [diff] [review]
Eliminate ambient noScriptRval, and make it live exclusively on CompileOptions. v1

Review of attachment 8464801 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, only 3 cx flags left :)
Attachment #8464801 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/3069d118d21d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.