934418 - Split RuntimeOptions off from ContextOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Eddy Bruel [:ejpbruel]]

Moving all the flags from the context to the runtime in one go turned out to be a bit too much to chew, so I've opened up two sub-bugs: bug 938907 removes the compile and go flag from ContextOptions completelty, and bug 939562 moves the JIT flags from the ContextOptions to RuntimeOptions.

Comment 2

[Eddy Bruel [:ejpbruel]]

I've opened separate bugs for each of the remaining flags, as we agreed on irc.

Comment 3

[Ben McCann]

8/9 blockers are done for this now!! Would be so so awesome to get that last one!

Comment 4

[Ben McCann]

Woohoo! 9/9 blockers are done for this now. Eddy, Bobby, is there any chance either of you guys would have a chance to look at this now with all the blocking work completed?

Comment 5

[Ben McCann]

You guys think you'll be able to look at this one?

Comment 6

[Jan de Mooij [:jandem]]

(In reply to Ben McCann from comment #5)
> You guys think you'll be able to look at this one?

I see you filed bug 885786 but note that the issue there should have been fixed a while ago, by bug 939562 and others. Fixing *this* bug is unlikely to help add-on performance.

If you still see cases where add-on JS is much slower than website JS I'd love to know about it!

Comment 7

[Ben McCann]

Ahh, thanks! So do you think it's wrong that bug 885786 is marked as depending on this bug?

Comment 8

[Jan de Mooij [:jandem]]

(In reply to Ben McCann from comment #7)
> Ahh, thanks! So do you think it's wrong that bug 885786 is marked as
> depending on this bug?

I changed it so bug 885786 depends on bug 939562 (fixed about a year ago) instead of this one. The remaining ContextOptions are not performance-sensitive.

Let me know if bug 885786 is still a problem for you, if it is please also try with a recent Nightly build and file a new bug. Thanks!

Comment 9

[Mayank Bansal]

All dependent bugs are closed. Closing this meta.