Closed Bug 940392 Opened 11 years ago Closed 11 years ago

'document.getElementById(...) is null' error in chatWindow.xul since Australis landed

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 28

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [Australis:P1])

Attachments

(1 file)

Attached patch FixSplinter Review
The Australis landing regressed bug 910288.

When detaching a SocialAPI floating window, I get this error in the Browser Console:
TypeError: document.getElementById(...) is null chatWindow.xul:82

It turns out the missing element that can't be disabled is 'Browser:ToggleAddonBar'; I guess it shouldn't be a surprise :).
Attachment #8334523 - Flags: review?(mixedpuppy)
Whiteboard: [Australis:P1]
Attachment #8334523 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/b3a32540b634
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Build ID: 20140310004003

Verified this issue on latest Aurora.
The mentioned error is no longer displayed when the user detaches a SocialAPI floating window.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: