940407 - Kill GTEST_SOURCES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Currently we can't port gfx/test/gtest because we don't support UNIFIED_GTEST_SOURCES.

Comment 1

[(no longer active)]

To see how we do this for WebIDL and IPDL generated code, see the usages of _add_unified_build_rules in python/mozbuild/mozbuild/backend/recursivemake.py.

Comment 2

[Mike Hommey [:glandium]]

webidl and ipdl are not the best examples.

Comment 3

[Mike Hommey [:glandium]]

Note i'm considering killing GTESTS_SOURCES shortly-ish.

Comment 4

[(no longer active)]

(In reply to comment #2)
> webidl and ipdl are not the best examples.

Can you please add some information on how BenWa should attack this then?

Comment 5

[Benoit Girard (:BenWa)]

(In reply to Mike Hommey [:glandium] from comment #3)
> Note i'm considering killing GTESTS_SOURCES shortly-ish.

Can you elaborate?

Comment 6

[Mike Hommey [:glandium]]

GTEST_SOURCES doesn't provide much added value over SOURCES, besides avoiding a check for MOZ_ENABLE_GTEST. And there are exactly three directories using GTEST_SOURCES. Sure there can be more in the future, but there's no reason the directory they're in can't be conditioned on MOZ_ENABLE_GTEST

Comment 7

[Mike Hommey [:glandium]]

even better... MOZ_ENABLE_GTEST is just a synonym for ENABLE_TESTS (considering what configure.in does)

Comment 8

[Benoit Girard (:BenWa)]

(In reply to Mike Hommey [:glandium] from comment #7)
> even better... MOZ_ENABLE_GTEST is just a synonym for ENABLE_TESTS
> (considering what configure.in does)

Ohh well I was hoping we could keep GTEST_SOURCES and have them live along side normal sources instead of requiring a separate directory. Ideally moz.build would do away with this limitation. But if that's not planed then it's sound fine to me.

Yes ENABLE_TESTS should be enough.

However it may be worth considering compiling gtest sources after a normal build similarly to how we lazy link xul.

Comment 9

[Mike Hommey [:glandium]]

(In reply to Benoit Girard (:BenWa) from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #7)
> > even better... MOZ_ENABLE_GTEST is just a synonym for ENABLE_TESTS
> > (considering what configure.in does)
> 
> Ohh well I was hoping we could keep GTEST_SOURCES and have them live along
> side normal sources instead of requiring a separate directory.

That's currently not possible anyways, because of how things are built. You'd always end up with gtest stuff in the normal libxul.

> Ideally moz.build would do away with this limitation. But if that's not planed then
> it's sound fine to me.

It is, but not quite right now.

> Yes ENABLE_TESTS should be enough.
> 
> However it may be worth considering compiling gtest sources after a normal
> build similarly to how we lazy link xul.

We're not lazy compiling currently. That will change in due time, but let's not worry about this now. So, I'll just kill GTEST_SOURCES now.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Kill GTEST_SOURCES

Comment 11

[Mike Hommey [:glandium]]

Attachment: Kill GTEST_SOURCES

Forgot to cleanup config/rules.mk and configure.in.

Comment 12

[Mike Hommey [:glandium]]

Attachment: Kill GTEST_SOURCES

With the python tests updated.

Comment 13

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07884241d31f

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07884241d31f