Open Bug 940705 Opened 7 years ago Updated 4 years ago

The separation between grouped/split toolbar icons in Australis could be made clearer still

Categories

(Firefox :: Theme, defect)

28 Branch
All
macOS
defect
Not set
minor

Tracking

()

People

(Reporter: maxim.chiriac, Assigned: shorlander)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P5])

Attachments

(1 file)

The redesigned toolbar in Australis isn't as intuitive as it is currently in Firefox. Notice how vertical bar visually separates buttons from their contextual dropdown buttons. I understand that there is increased spacing between buttons now, but it appears a little confusing at first glance where dropdowns belong to.

Attached image illustrates the issue with screenshots from Firefox and Australis side by side. However, issue is more obvious when looked solely in Australis.
interface, toolbar, buttons, UI
Summary: Perception of grouped toolbar icons in Australis. Interface issue. → The separation between grouped/split toolbar icons in Australis is unclear
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 856665
No longer blocks: australis-buttons
Component: Toolbars and Customization → Theme
OS: All → Mac OS X
P3 to figure out what to do here. Stephen, is the screenshot by design, or are we missing an aspect of the spec here?
Flags: needinfo?(shorlander)
Whiteboard: [Australis:P3]
(In reply to :Gijs Kruitbosch from comment #2)
> P3 to figure out what to do here. Stephen, is the screenshot by design, or
> are we missing an aspect of the spec here?

It is by design, but it is probably worth taking another pass to see if the visual grouping is right. Split buttons might just need to be tighter or we might need put them in a container.
Flags: needinfo?(shorlander)
Part of the problem is in fact that vertical bar is usually used as a separator. It was OK to use it in Firefox when buttons where standing out a bit, but with new Australis flat design it is less clear. Perhaps vertical bar could be dropped completely? Any other suggestions?
 
I am not a designer, and I would not want to ruin the new design ideas. I really think it looks nice. However, this was my immediate concern after installing Australis. And when I've showed it to my colleague, he pointed out tho the same issue.

I just think Firefox is the best browser, and I want it to remain as that forever. Many little details make it shine, so I think it is important continue to pay attention to them. However, if community thinks this "issue" isn't an issue, I am fine to leave it as is.
Assignee: nobody → shorlander
Take another pass or not? (comment 3)

Calling this P4 since it doesn't seem to be a common issue.
Flags: needinfo?(shorlander)
Whiteboard: [Australis:P3] → [Australis:P4]
(In reply to Justin Dolske [:Dolske] from comment #5)
> Take another pass or not? (comment 3)
> 
> Calling this P4 since it doesn't seem to be a common issue.

I won't mess with the priority but I think the visual group here is a little off. Bookmark widget has the same issue. I hope to have a patch with adjusted padding before release.
Flags: needinfo?(shorlander)
Duplicate of this bug: 972258
Whiteboard: [Australis:P4] → [Australis:P3-]
I think this is better enough now that we don't need to do much if anything here. Stephen, do you concur?
Flags: needinfo?(shorlander)
(In reply to :Gijs Kruitbosch from comment #8)
> I think this is better enough now that we don't need to do much if anything
> here. Stephen, do you concur?

Yes. I think this is mostly fixed by bug 909349. Might be some tweaking we could do WRT to button spacing this looks good for now.
Flags: needinfo?(shorlander)
Summary: The separation between grouped/split toolbar icons in Australis is unclear → The separation between grouped/split toolbar icons in Australis could be made clearer still
Whiteboard: [Australis:P3-] → [Australis:P5]
I think it looks much better now. Thanks guys!

Couple questions.
* There is a "Share This Page" toolbar button in Australis that does not do anything but is clickable (not in "disabled" state), is this a bug or work in progress?
* Also, when removing 1Password add-on button from toolbar by context menu "Remove from Toolbar" it appears back in toolbar after restarting Australis.

My apologies if these questions should be asked outside of this thread. Not sure if there are discussion areas for this type of things.
(In reply to Max from comment #10)
> I think it looks much better now. Thanks guys!
> 
> Couple questions.
> * There is a "Share This Page" toolbar button in Australis that does not do
> anything but is clickable (not in "disabled" state), is this a bug or work
> in progress?

The Share button should only be on if it is tied to the a service activated in the Social API AFAIK.

> * Also, when removing 1Password add-on button from toolbar by context menu
> "Remove from Toolbar" it appears back in toolbar after restarting Australis.

Seems like a different (new?) bug.
You need to log in before you can comment on or make changes to this bug.