940705 - The separation between grouped/split toolbar icons in Australis could be made clearer still

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Max]

Attachment: side by side screenshots from Firefox 25 and new Australis interface

The redesigned toolbar in Australis isn't as intuitive as it is currently in Firefox. Notice how vertical bar visually separates buttons from their contextual dropdown buttons. I understand that there is increased spacing between buttons now, but it appears a little confusing at first glance where dropdowns belong to.

Attached image illustrates the issue with screenshots from Firefox and Australis side by side. However, issue is more obvious when looked solely in Australis.

Comment 1

[Max]

interface, toolbar, buttons, UI

Comment 2

[:Gijs (he/him)]

P3 to figure out what to do here. Stephen, is the screenshot by design, or are we missing an aspect of the spec here?

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #2)
> P3 to figure out what to do here. Stephen, is the screenshot by design, or
> are we missing an aspect of the spec here?

It is by design, but it is probably worth taking another pass to see if the visual grouping is right. Split buttons might just need to be tighter or we might need put them in a container.

Comment 4

[Max]

Part of the problem is in fact that vertical bar is usually used as a separator. It was OK to use it in Firefox when buttons where standing out a bit, but with new Australis flat design it is less clear. Perhaps vertical bar could be dropped completely? Any other suggestions?
 
I am not a designer, and I would not want to ruin the new design ideas. I really think it looks nice. However, this was my immediate concern after installing Australis. And when I've showed it to my colleague, he pointed out tho the same issue.

I just think Firefox is the best browser, and I want it to remain as that forever. Many little details make it shine, so I think it is important continue to pay attention to them. However, if community thinks this "issue" isn't an issue, I am fine to leave it as is.

Comment 5

[Justin Dolske [:Dolske]]

Take another pass or not? (comment 3)

Calling this P4 since it doesn't seem to be a common issue.

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to Justin Dolske [:Dolske] from comment #5)
> Take another pass or not? (comment 3)
> 
> Calling this P4 since it doesn't seem to be a common issue.

I won't mess with the priority but I think the visual group here is a little off. Bookmark widget has the same issue. I hope to have a patch with adjusted padding before release.

Comment 8

[:Gijs (he/him)]

I think this is better enough now that we don't need to do much if anything here. Stephen, do you concur?

Comment 9

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #8)
> I think this is better enough now that we don't need to do much if anything
> here. Stephen, do you concur?

Yes. I think this is mostly fixed by bug 909349. Might be some tweaking we could do WRT to button spacing this looks good for now.

Comment 10

[Max]

I think it looks much better now. Thanks guys!

Couple questions.
* There is a "Share This Page" toolbar button in Australis that does not do anything but is clickable (not in "disabled" state), is this a bug or work in progress?
* Also, when removing 1Password add-on button from toolbar by context menu "Remove from Toolbar" it appears back in toolbar after restarting Australis.

My apologies if these questions should be asked outside of this thread. Not sure if there are discussion areas for this type of things.

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to Max from comment #10)
> I think it looks much better now. Thanks guys!
> 
> Couple questions.
> * There is a "Share This Page" toolbar button in Australis that does not do
> anything but is clickable (not in "disabled" state), is this a bug or work
> in progress?

The Share button should only be on if it is tied to the a service activated in the Social API AFAIK.

> * Also, when removing 1Password add-on button from toolbar by context menu
> "Remove from Toolbar" it appears back in toolbar after restarting Australis.

Seems like a different (new?) bug.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 13

[:Gijs (he/him)]

All of these split buttons have disappeared from the default set.