[UITest][polish] Add landscape mode and layout adjustment

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tjao, Assigned: tjao)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Due to some CSS changes, UITest app now shows incorrectly in landscape orientation. We can fix it by media query or some other means.
(Assignee)

Updated

5 years ago
Assignee: nobody → tjao
(Assignee)

Updated

5 years ago
Blocks: 883714
(Assignee)

Comment 2

5 years ago
Also some clean ups using flexbox.

Comment 3

5 years ago
Looks pretty good to me.

I think it will be better to unify all title bar/bottom tabs height to 2~3rem in both land and portrait mode.
Would you like to do it in another bug?

Updated

5 years ago
Attachment #8343541 - Flags: review?(gasolin) → review+
(Assignee)

Comment 4

5 years ago
OK. Since it's not merged, I add this adjustment in this PR.
Summary: [UITest][polish] tests menu shows incorrectly in landscape mode → [UITest][polish] Add landscape mode and layout adjustment
(Assignee)

Updated

5 years ago
Attachment #8343541 - Flags: review+ → review?(gasolin)

Updated

5 years ago
Attachment #8343541 - Flags: review?(gasolin) → review+

Comment 5

5 years ago
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/3a78051b6deb056f42b5cc168626d4d410f3bd3e

thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.