Closed
Bug 940824
Opened 12 years ago
Closed 12 years ago
[UITest][polish] Add landscape mode and layout adjustment
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tjao, Assigned: tjao)
References
Details
Attachments
(1 file)
Due to some CSS changes, UITest app now shows incorrectly in landscape orientation. We can fix it by media query or some other means.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → tjao
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8343541 -
Flags: review?(gasolin)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Also some clean ups using flexbox.
|
||
Comment 3•12 years ago
|
||
Looks pretty good to me.
I think it will be better to unify all title bar/bottom tabs height to 2~3rem in both land and portrait mode.
Would you like to do it in another bug?
|
|
||
Updated•12 years ago
|
Attachment #8343541 -
Flags: review?(gasolin) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
OK. Since it's not merged, I add this adjustment in this PR.
Summary: [UITest][polish] tests menu shows incorrectly in landscape mode → [UITest][polish] Add landscape mode and layout adjustment
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8343541 -
Flags: review+ → review?(gasolin)
|
|
||
Updated•12 years ago
|
Attachment #8343541 -
Flags: review?(gasolin) → review+
|
|
||
Comment 5•12 years ago
|
||
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/3a78051b6deb056f42b5cc168626d4d410f3bd3e
thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•