Closed Bug 940838 Opened 7 years ago Closed 7 years ago

Clicking tab does not switch tab after popup Nav-Bar-overflow panel

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 29

People

(Reporter: alice0775, Assigned: cpt.at.work)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3][good first bug][lang=xul][mentor=dao])

Attachments

(1 file)

No description provided.
Nav-Bar-overflow panel should be same behavior as Download panel and PanelUI

Steps To Reproduce:
1. Click Nav-Bar-overflow button
2. Crick a background tab

Actual Results:
 Nav Bar overflow closed
 But tab is not changed

Expected Results:
 Clicked tab should be selected and foreground
Severity: normal → minor
Summary: NavBar → Clicking tab does not switch tab after popup Nav-Bar-overflow panel
Severity: minor → normal
Whiteboard: [Australis:P3]
Save fix as bug 934988?
(In reply to Justin Dolske [:Dolske] from comment #2)
> Save fix as bug 934988?

indeed
Assignee: nobody → dao
We need to remove consumeoutsideclicks="true" from the "widget-overflow" panel:

http://hg.mozilla.org/mozilla-central/annotate/530209bff5e8/browser/components/customizableui/content/panelUI.inc.xul#l172
Assignee: dao → nobody
Whiteboard: [Australis:P3] → [Australis:P3][good first bug][lang=xul][mentor=dao]
Hi, 
I would like to work on this work. Can you please assign it to me.
Assignee: nobody → cpt.at.work
Does the down-arrow in the nav-bar called the Nav-Bar-overflow button. If so, I can reproduce the bug even in Linux Platform. And I couldn't fix it after removing consumeoutsideclicks="true" from the "widget-overflow" panel.
(In reply to cptanu from comment #6)
> Does the down-arrow in the nav-bar called the Nav-Bar-overflow button. If
> so, I can reproduce the bug even in Linux Platform.

Yes, it exists on Linux too.

> And I couldn't fix it
> after removing consumeoutsideclicks="true" from the "widget-overflow" panel.

Did you remove the attribute at runtime or did you modify the source and build it?
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 28 Branch → Trunk
I modified the source code and build it. And it didn't work.
OS: All → Windows 7
Hardware: All → x86_64
Version: Trunk → 28 Branch
Sorry I did it by mistake.
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 28 Branch → Trunk
(In reply to cptanu from comment #8)
> I modified the source code and build it. And it didn't work.

Works just fine over here on Linux.
Attached patch patch.patchSplinter Review
Attachment #8359820 - Flags: review?(dao)
Comment on attachment 8359820 [details] [diff] [review]
patch.patch

thanks
Attachment #8359820 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/353b5ee29838
Keywords: checkin-needed
Whiteboard: [Australis:P3][good first bug][lang=xul][mentor=dao] → [Australis:P3][good first bug][lang=xul][mentor=dao][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/353b5ee29838
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][good first bug][lang=xul][mentor=dao][fixed-in-fx-team] → [Australis:P3][good first bug][lang=xul][mentor=dao]
Target Milestone: --- → Firefox 29
QA Contact: cornel.ionce
Verified as fixed using the STR from comment 1 on latest Nightly (build ID: 20140317165801) and on latest Aurora (build ID: 20140317004002).
Tested on Windows 7 64 bit, Ubuntu 12.04 and Mac OS X 10.9.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.