Closed
Bug 941058
Opened 11 years ago
Closed 11 years ago
Buttons in titlebar swapped in RTL UI
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: smontagu, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: rtl, Whiteboard: [Australis:P1])
Attachments
(2 files, 2 obsolete files)
|
23.67 KB,
image/png
|
Details | |
|
4.31 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Screen Shot of the titlebar
In Australis RTL UI in OSX the close/minimize/zoom buttons are at the right of the titlebar and the go-full-screen control on the left, swapped from the way they appear in all other windows.
|
Reporter | |
Comment 1•11 years ago
|
||
Gijs asked me to needinfo mstange on this
Flags: needinfo?(mstange)
|
||
Updated•11 years ago
|
Blocks: australis-merge
|
Assignee | |
Comment 2•11 years ago
|
||
I discussed this with Markus on IRC. The problem is actually pretty simple: because of bug 851652, we now draw the titlebar buttons based on the frames of the elements in the #titlebar. Those get reordered in RTL, and we need to ensure that that only happens on non-mac. We should probably remove the #ifdefs for this in browser.xul and instead use browser/base/content/browser.css that takes RTL into account.
Assignee: nobody → gijskruitbosch+bugs
Blocks: australis-tabs
Status: NEW → ASSIGNED
Depends on: 851652
Flags: needinfo?(mstange)
Whiteboard: [Australis:P1]
|
|
Assignee | |
Comment 3•11 years ago
|
||
Moving the code to browser/base because themes shouldn't have to worry about getting this right.
Attachment #8335416 -
Flags: review?(mdeboer)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Good thing you made me check, there was another issue with this patch...
Attachment #8335443 -
Flags: review?(mdeboer)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8335416 -
Attachment is obsolete: true
Attachment #8335416 -
Flags: review?(mdeboer)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8335443 [details] [diff] [review]
titlebar buttons are swapped in RTL mode,
Review of attachment 8335443 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/browser.xul
@@ +430,1 @@
> #endif
I think you can remove this entire #ifndef block and move it browser/base/content/browser.css
Attachment #8335443 -
Flags: review?(mdeboer) → review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8335443 -
Attachment is obsolete: true
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8335967 [details] [diff] [review]
[Australis] titlebar buttons are swapped in RTL mode,
Review of attachment 8335967 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome, we're there!
Attachment #8335967 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Whiteboard: [Australis:P1] → [Australis:P1][fixed-in-fx-team]
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•