941123 - Double-tap to zoom out fails to render surround content

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Jim Mathies [:jimm]]

STR:

1) open a page with a dark background (daringfireball.net)
2) double tap to zoom in on a paragraph
3) double tap anywhere to zoom out

result: on the zoom out, content surrounding the zoomed view isn't refreshed until the zoom operation completes.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

We need to send a call to GeckoContentController::RequestContentRepaint with mEndZoomToMetrics at the end of AsyncPanZoomController::ZoomToRect in order to improve the responsiveness here. We do the equivalent thing in Fennec too.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

When zooming out, this patch is a clear win.

When zooming in, it's a mixed bag.  It means that the content is repainted at the higher resolution right away, instead of after a delay (e.g. text is no longer "fuzzy" initially).  But it can cause a flash of white around the area that's not part of the new displayport.  Bug 785933 would help to mitigate the flash-of-white problem.

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8335656 [details] [diff] [review]
patch

Review of attachment 8335656 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +1451,5 @@
> +                          &GeckoContentController::RequestContentRepaint,
> +                          mEndZoomToMetrics),
> +        GetFrameTime());
> +      mLastPaintRequestMetrics = mEndZoomToMetrics;
> +    }

This code is very similar to code at the end of AsyncPanZoomController::RequestContentRepaint(). Could we break it out into a helper function?

Comment 5

[Matt Brubeck (:mbrubeck)]

https://tbpl.mozilla.org/?tree=Try&rev=ced11aa2eec1

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to Botond Ballo [:botond] from comment #4)
> This code is very similar to code at the end of
> AsyncPanZoomController::RequestContentRepaint(). Could we break it out into
> a helper function?

Done:
https://hg.mozilla.org/integration/mozilla-inbound/rev/763eb940987b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/763eb940987b