941328 - Double-tap to zoom out always scrolls to the top of the page

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Install/Update, defect)

Description

[Matt Brubeck (:mbrubeck)]

Instead of scrolling to the top of the page, we should zoom out to an area of the page that is roughly centered on the tapped/zoomed location, so that the same part of the document is still visible.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

It turns out APZC will automatically zoom out if we pass an empty rect.

Comment 2

[Marco Mucci [:MarcoM]]

Hey Matt, can you provide a point value.

Comment 3

[Matt Brubeck (:mbrubeck)]

p=1 (or just add this a work item to the double-tap story)

Comment 4

[Allison Naaktgeboren :ally]

Comment on attachment 8335665 [details] [diff] [review]
patch

Review of attachment 8335665 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I wonder why (0,0,0,0) would no-op for me.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/69fb4a0fc17f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69fb4a0fc17f