941345 - sim change not detected

Status: RESOLVED DUPLICATE of bug 999311

(Firefox OS Graveyard :: RIL, defect)

Description

[Dietrich Ayala (:dietrich)]

master + mozilla-central, Nexus 4 (JB).

When i pull sim card out and put a new one in, it should show a notification saying the phone should be restarted.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Dietrich,

Is this bug about Gaia didn't report SIMcard missing(Bug 940297) or Gaia should asks the users to reboot ?

Thanks

Comment 2

[shawn ku [:sku]]

Hi Yoshi:
 I guess Dietrich is talking a feature in AOSP.


When remove SIM -> Insert a new SIM.
AOSP will pop a dailog to notify user there is a SIM hotswap occurred.
After user click ok, device will reboot.

// AOSP prompt strings 
    <!-- See SIM_ADDED_DIALOG.  This is the title of that dialog. -->
    <string name="sim_added_title">SIM card added</string>
    <!-- See SIM_ADDED_DIALOG.  This is the message of that dialog. -->
    <string name="sim_added_message">Restart your device to access the mobile network.</string>
    <!-- See SIM_ADDED_DIALOG.  This is the button of that dialog. -->
    <string name="sim_restart_button">Restart</string>

// Code
frameworks/opt/telephony/src/java/com/android/internal/telephony/uicc/UiccCard.java

    private void onIccSwap(boolean isAdded) {
        synchronized (mLock) {
            // TODO: Here we assume the device can't handle SIM hot-swap
            //      and has to reboot. We may want to add a property,
            //      e.g. REBOOT_ON_SIM_SWAP, to indicate if modem support
            //      hot-swap.
            DialogInterface.OnClickListener listener = null;


            // TODO: SimRecords is not reset while SIM ABSENT (only reset while
            //       Radio_off_or_not_available). Have to reset in both both
            //       added or removed situation.
            listener = new DialogInterface.OnClickListener() {
                @Override
                public void onClick(DialogInterface dialog, int which) {
                    synchronized (mLock) {
                        if (which == DialogInterface.BUTTON_POSITIVE) {
                            if (DBG) log("Reboot due to SIM swap");
                            PowerManager pm = (PowerManager) mContext
                                    .getSystemService(Context.POWER_SERVICE);
                            pm.reboot("SIM is added.");
                        }
                    }
                }

            };

            Resources r = Resources.getSystem();

            String title = (isAdded) ? r.getString(R.string.sim_added_title) :
                r.getString(R.string.sim_removed_title);
            String message = (isAdded) ? r.getString(R.string.sim_added_message) :
                r.getString(R.string.sim_removed_message);
            String buttonTxt = r.getString(R.string.sim_restart_button);

            AlertDialog dialog = new AlertDialog.Builder(mContext)
            .setTitle(title)
            .setMessage(message)
            .setPositiveButton(buttonTxt, listener)
            .create();
            dialog.getWindow().setType(WindowManager.LayoutParams.TYPE_SYSTEM_ALERT);
            dialog.show();
        }
    }

Comment 3

[Dietrich Ayala (:dietrich)]

Correct, nothing at all happened.

Comment 4

[Ken Chang[:kenkai]]

Put it in backlog.