Build jsapi-tests in unified mode

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 8336002 [details] [diff] [review]
Patch

There's a whole bunch of them and this should hopefully make building the shell and browser slightly faster.

There was only one real problem: two tests used a |callCount| variable. I cleaned up a bunch of other tests too though, in particular moving functions between BEGIN_TEST and END_TEST makes them class members, making them less likely to clash with other tests in the future.
Attachment #8336002 - Flags: review?(luke)
Attachment #8336002 - Flags: review?(ehsan)
Comment on attachment 8336002 [details] [diff] [review]
Patch

Review of attachment 8336002 [details] [diff] [review]:
-----------------------------------------------------------------

(Note that I only skimmed the code changes, but everything looks good to me!)
Attachment #8336002 - Flags: review?(ehsan) → review+

Updated

5 years ago
Attachment #8336002 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/371af5899d27
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.