Closed
Bug 941590
Opened 11 years ago
Closed 11 years ago
Build jsapi-tests in unified mode
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jandem, Assigned: jandem)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
36.44 KB,
patch
|
ehsan.akhgari
:
review+
luke
:
review+
|
Details | Diff | Splinter Review |
There's a whole bunch of them and this should hopefully make building the shell and browser slightly faster.
There was only one real problem: two tests used a |callCount| variable. I cleaned up a bunch of other tests too though, in particular moving functions between BEGIN_TEST and END_TEST makes them class members, making them less likely to clash with other tests in the future.
Attachment #8336002 -
Flags: review?(luke)
Attachment #8336002 -
Flags: review?(ehsan)
Comment 1•11 years ago
|
||
Comment on attachment 8336002 [details] [diff] [review]
Patch
Review of attachment 8336002 [details] [diff] [review]:
-----------------------------------------------------------------
(Note that I only skimmed the code changes, but everything looks good to me!)
Attachment #8336002 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Updated•11 years ago
|
Attachment #8336002 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Try looks good, pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/371af5899d27
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•