Closed Bug 941590 Opened 7 years ago Closed 7 years ago

Build jsapi-tests in unified mode

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jandem, Assigned: jandem)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
There's a whole bunch of them and this should hopefully make building the shell and browser slightly faster.

There was only one real problem: two tests used a |callCount| variable. I cleaned up a bunch of other tests too though, in particular moving functions between BEGIN_TEST and END_TEST makes them class members, making them less likely to clash with other tests in the future.
Attachment #8336002 - Flags: review?(luke)
Attachment #8336002 - Flags: review?(ehsan)
Comment on attachment 8336002 [details] [diff] [review]
Patch

Review of attachment 8336002 [details] [diff] [review]:
-----------------------------------------------------------------

(Note that I only skimmed the code changes, but everything looks good to me!)
Attachment #8336002 - Flags: review?(ehsan) → review+
Attachment #8336002 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/371af5899d27
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.