941648 - SocialAPI status buttons shouldn't be visible in toolbarless browser windows

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot of the Persona dialog with an additional social status button

(See attached screenshot)

Clicking the button results in a JS error:
JavaScript error: resource:///modules/SharedFrame.jsm, line 137: NS_ERROR_NOT_IMPLEMENTED: 

Steps to reproduce:
- Install a social API provider that defines a statusURL, so that it gets a status button. (For the screenshot, I used talkilla where I replaced "sidebarURL" with "statusURL" in the file static/js/browserDetection.js)
- Open a Persona dialog.

Comment 1

[Florian Quèze [:florian]]

Attachment: bug-status-button-toolbarless-window.patch

Comment 2

[Florian Quèze [:florian]]

Setting status/tracking flags. This code was already in Firefox 26, but it wasn't possible to trigger it until we pref'ed it on in bug 906839; which happened for Firefox 27, so I think we should fix this on trunk and 27.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8336103 [details] [diff] [review]
bug-status-button-toolbarless-window.patch

This looks good, and I was already considering this change in a different patch.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/04488590113d

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8336103 [details] [diff] [review]
bug-status-button-toolbarless-window.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): The feature (SocialAPI status buttons) was implemented in bug 891225 and enabled in bug 906839.
User impact if declined: Broken toolbar buttons in toolbarless browser windows if the user has installed a SocialAPI provider providing a statusURL.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low (only css class changes).
String or IDL/UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04488590113d

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/64b99c299be9

Comment 8

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using the latest Firefox 27 beta 1 (20131209204824) on Win 7 64-bit, Ubuntu 32-bit and Mac OS X 10.8.5.

I reproduced the initial issue following the next steps (from Florian):
1. Go to https://talkilla-dev.mozillalabs.com/ 
2. Add a security exception for the certificate. 
3. Click the "Activate Talkilla" button and accept. 
4. Find the new toolbar button that appeared, and click it. 
5. Wait for the content of the panel to load then click the "sign in with Persona" button in there.

Comment 9

[Ioana (away)]

I tried to reproduce/verify this fix but it works the same for Firefox 26b10, 27b1 and 28a2. No SocialAPI icon is displayed anywhere in the persona dialog. I used the steps in comment 8 and variations of them (e.g. open the persona dialog from somewhere else, open another toolbarless window etc).

Petruta, since you could reproduce this issue, please verify it on Firefox 28 too.

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed on latest Aurora 28.0a2 (20131215004001) on Win 7 64-bit, Ubuntu 64-bit and Mac OS X 10.9.