Closed Bug 941655 Opened 11 years ago Closed 10 years ago

[Download Manager] Update time strings within download list

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S2 (28feb)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: noemi, Assigned: borjasalguero)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

Pull Request
46 bytes, text/x-github-pull-request
kaze
: review+
Details | Review 
Refresh the time strings (just now, 1min ago...) within the download list while it is open
Assignee: nobody → borja.bugzilla
Blocks: 935082
Whiteboard: [systemsfe]
Blocks: 906257
No longer blocks: 935082
Depends on: 935088
Attached file Pull request (obsolete) — 

        Attachment #8360400 -
        Flags: review?(kaze)

    
  

        Attachment #8360400 -
        Flags: review?(francisco.jordano)

    
    

    
  
Comment on attachment 8360400 [details] [review]
Pull request

r=me

With some comments on github, not really blocking.

Tried on the phone and it's updates the list smoothly.

Thanks a lot!

        Attachment #8360400 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Comments addressed!

    
    

    
  
Comment on attachment 8360400 [details] [review]
Pull request

R=me with the last nit addressed.

        Attachment #8360400 -
        Flags: review?(kaze) → review+

    
  
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)

    
    

    
  
Fun story, we're running Gaia unit tests on TBPL now and this caused perma-fail. Reverted.
https://github.com/mozilla-b2g/gaia/commit/0bc0e703df197d46dfffb9ac65cb85d2e3e10c4a

https://tbpl.mozilla.org/php/getParsedLog.php?id=33755141&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.3 C3/1.4 S3(31jan) → 1.4 S1 (14feb)

    
    

    
  

      
      
      
      

        Attached file
          
        Pull Request
        — 
      

    


  
Kaze! At the end this code was reverted due to the timeout we were discussing, and now this timeout is not in Gaia anymore (previous discussion here https://github.com/mozilla-b2g/gaia/pull/15356#issuecomment-32834494). So it's the same code without that line. Could you take a look? Thanks!

        Attachment #8360400 -
        Attachment is obsolete: true

        Attachment #8374726 -
        Flags: review?(kaze)
blocking-b2g: --- → 1.4+

    
    

    
  
Comment on attachment 8374726 [details] [review]
Pull Request

LGTM, thanks for the explanation Borja. :-)

        Attachment #8374726 -
        Flags: review?(kaze) → review+
Target Milestone: 1.4 S1 (14feb) → 1.4 S2 (28feb)

    
    

    
  
As this is a 1.4+ bug and it's r+, and Travis is green, merging.

https://github.com/mozilla-b2g/gaia/commit/b7b2741c0c2c13c926573cbf570aef14c3f81726
https://github.com/borjasalguero/gaia/commit/1e6949eaea6cb23be1de5955fc6b0827af7b40f0
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

    
    

    
  
Patch author: please don't forget to include the bug number in your commits.
Reviewers: please check that the number is present.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: