941740 - How Am I supose to move the window on my screen ?

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ludovic Hirlimann [:Usul]]

Attachment: No place to click and move the window

In the latest Mac nightly I have One pixel above the tabs to move my window or a few pixels below the Three red, yeallow and green button?

This makes moving the main window a PITA.

Is it a bug or a feature ?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is almost certainly fallout from the Australis landing.

Comment 2

[Richard Marti (:Paenglab)]

Until this is fixed, you can set mail.tabs.drawInTitlebar to false.

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to Richard Marti [:Paenglab] from comment #2)
> Until this is fixed, you can set mail.tabs.drawInTitlebar to false.

that did it.

Comment 4

[Josiah Bruner [:jsbruner]]

I'll have a fix up as soon as I can build again...

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to Ludovic Hirlimann [:Usul] from comment #3)
> (In reply to Richard Marti [:Paenglab] from comment #2)
> > Until this is fixed, you can set mail.tabs.drawInTitlebar to false.
> 
> that did it.

Not entirely. I have a MBP with an external HD screen attached. From my time to time, moving a perfectly correctly drawn window from the external screen to the Retina LCD screen will make the window badly redraw its titlebar, just like ludovic's screenshot. And even if the pref mentioned above is set to false.
I also have some whitelisted popups that appear badly drawn and are impossible to move.
From time to time too, but I'm unable to give precise steps, a new window is badly drawn despite of the pref to false.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Daniel Glazman (:glazou) from comment #5)
> (In reply to Ludovic Hirlimann [:Usul] from comment #3)
> > (In reply to Richard Marti [:Paenglab] from comment #2)
> > > Until this is fixed, you can set mail.tabs.drawInTitlebar to false.
> > 
> > that did it.
> Not entirely. I have a MBP with an external HD screen attached. From my time
> to time, moving a perfectly correctly drawn window from the external screen
> to the Retina LCD screen will make the window badly redraw its titlebar,
> just like ludovic's screenshot. And even if the pref mentioned above is set
> to false.

The pref is only a quick workaround and where are CSS styles and other thing missing to work correctly.

> I also have some whitelisted popups that appear badly drawn and are
> impossible to move.

I saw bug reports for Fx for popup windows without tab bar showing no title bar and the window buttons in the URL bar.

> From time to time too, but I'm unable to give precise steps, a new window is
> badly drawn despite of the pref to false.

Comment 7

[Josiah Bruner [:jsbruner]]

So this should be fixed by bug 768516, but I'll keep this open until we know for sure.

Comment 9

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

This should fix things using a small amount of XUL changes, and little CSS. However, we will want to back this out (or undo it) when we go to land the patch for tabs in the titlebar.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8337934 [details] [diff] [review]
Fix.

Review of attachment 8337934 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, I think we can take care of the default case in a simpler way - simply set the default of mail.tabs.drawInTitlebar to false in mail/app/profile for OS X (you'll need to wrap with an #ifdef for XP_MACOSX).

So I think the strategy here will be:

Land that pref off for Daily, and allow it to merge to Earlybird at merge time. At merge time, Holly will merge into mozilla-aurora, which will mean the OS X will be removed from the CAN_DRAW_IN_TITLEBAR list, and all should be well again. We can leave the pref as it is, since it's behind an ifdef, and OS X will just be ignored.

We'll need to take care of the lightweight theme case as well when not drawing tabs in the titlebar, but then again, so will Firefox. We should file a bug on that.

Comment 11

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Sounds like a good idea to me. Here's the patch. (Also includes the necessary CSS fix for lw-themes)

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8338032 [details] [diff] [review]
Fix.

Review of attachment 8338032 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure to fix / test the no-lwtheme case, and then I think we're good to go.

Thanks Josiah!

::: mail/themes/osx/mail/messenger.css
@@ +20,5 @@
>     */
>    margin-bottom: 0px !important;
>  }
>  
> +#titlebar:-moz-lwtheme {

We'll need to hide a rule for the titlebar to be hidden if we're not using a -moz-lwtheme.

Comment 13

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Thanks!

Comment 14

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Comment 15

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/aae6a4e00030

Comment 16

[Magnus Melin [:mkmelin]]

Remember to set the target milestone to when it landed on trunk.