Closed Bug 94180 Opened 23 years ago Closed 23 years ago

Grippy appears to the left instead of center (for addressbook and vert 3 pane)

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: nbaca, Assigned: sspitzer)

References

Details

(Keywords: regression, Whiteboard: PDT+)

Attachments

(4 files)

Holy nonsensical XUL, Batman.
817 bytes, patch
Details | Diff | Splinter Review
Fix (ignore the code at the top)
1.68 KB, patch
kerz
: review+
hyatt
: superreview+
Details | Diff | Splinter Review
fix for alt-3pane
910 bytes, patch
stephend
: review+
sspitzer
: superreview+
Details | Diff | Splinter Review
here's the patch for the branch
1.63 KB, patch
sspitzer
: review+
sspitzer
: superreview+
Details | Diff | Splinter Review 
Build 2001-08-06-03: WinMe
Build 2001-08-06-08: Mac 9.04
haven't tried linux

Overview: When Mail opens the grippy on the horizontal splitter (b/n thread pane
and message pane) appears to the left. This problem occurs with Modern and
Classic themes. 

Actual Results:
- Mac: Modern, Select the grippy and it moves to the center
- Mac: Classic, Select the grippy and it remains to the left
- Win: Modern, Select the grippy and it moves to the center
- Win: Classic, Select the grippy and it moves to the center
Hewitt suggested that I assign this bug to Hyatt.
Assignee: sspitzer → hyatt
QA Contact: esther → nbaca
Keywords: mozilla0.9.4, regression
OS: other → All
dave/joe, why is this occurring? just curious. appears to be a recent
regression.
Keywords: nsBranch
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.4
This seems worthy to me. 

David/Petetr - Can we get a nsbranch+? 

Nominating for PDT+ approval.
Whiteboard: PDT
Blocks: 99227
Dave, what's the status of this bug?  Are you the right owner?

I wouldn't call this a stop-ship, but if you have a one-liner it would be worth
taking if it shows up RSN.
I think I know what the problem is now.  If I'm right, it will be a one-liner.

Attributes on the splitter that shouldn't have been there are removed in this 
patch.  It fixes the problem.

Ready for r/sr.

r=brendan@mozilla.org, but do we really need a XUL schema, or should old/bad
attributes be diagnosed to the console (or ignored)?

/be
We could start spitting out deprecation warnings, but there would be literally 
hundreds of them during the loading of mailnews or navigator. :)

0.9.4 is out the door
Target Milestone: mozilla0.9.4 → mozilla0.9.5
nsbranch+
Keywords: nsbranch → nsbranch+
I hope it works!  r=hwaara   ;)

Now checkin this baby.
Fixed on branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
with a current linux CVS build, now *I* for the first time see the grippy to the
far left instead of centered. This is weird.
again: this horked alternate threepane. Confirmed on both Linux and Windows:
The splitter that used to be placed in center untill this fix went in, is now to
the far left.
I'm using alternate 3-pane, and the grippy hasn't been and still isn't centered
with the September 23 win32 build.  Same with the addressbook.
*** Bug 101266 has been marked as a duplicate of this bug. ***
From bug 101266, just noting that addressbook ha(s/d) this problem, too.
resizing the horisontal splitter makes the grippy "snap" to position. 
(Both mailnews and AB) But it's always to the left on next startup.
this is  fixed on windows and linux (both trunk and branch)..but it still exists 
on mac and mac osx.

reopening
Status: RESOLVED → REOPENED
Hardware: All → Macintosh
Resolution: FIXED → ---
The fix I attached fixes the addressbook's splitter.
Comment on attachment 50663 [details] [diff] [review]
Fix (ignore the code at the top)

r=kerz
Attachment #50663 - Flags: review+
Comment on attachment 50663 [details] [diff] [review]
Fix (ignore the code at the top)

sr=hyatt
Attachment #50663 - Flags: superreview+
I checked in the fix for address book's splitter.
This is still broken on 09/25 builds using win32 and the alternate 3-pane.  The
addressbook is fixed though.
Reassigning to component owner to fix their remaining XUL files.
Assignee: hyatt → sspitzer
Status: REOPENED → NEW
QA Contact: nbaca → esther

    
    

    
  
Seth/mscott - We want this one. - PDT

    
    

    
  
Comment on attachment 50717 [details] [diff] [review]
fix for alt-3pane

sr=sspitzer

        Attachment #50717 -
        Flags: superreview+

    
    

    
  
if I get PDT+, I'll land both the addressbook and the alt 3 pane on the 0.9.4 
branch.
Status: NEW → ASSIGNED

    
    

    
  
I landed the alt-3pane fix on the trunk.

    
  
Blocks: 99508
Summary: Grippy appears to the left instead of center → Grippy appears to the left instead of center (for addressbook and vert 3 pane)

    
    

    
  
Comment on attachment 50831 [details] [diff] [review]
here's the patch for the branch

this has been reviewed and super-reviewed, just waiting for pdt

        Attachment #50831 -
        Flags: superreview+

        Attachment #50831 -
        Flags: review+

    
  
QA Contact: esther → olgam

    
    

    
  
check it in today - PDT+
Whiteboard: PDT → PDT+

    
    

    
  
fixed on branch and trunk, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Hardware: Macintosh → All
Resolution: --- → FIXED

    
    

    
  
verified fixed on mac commercial builds: 
mac 2001-09-27-03-0.9.4
mac 2001-09-27-04-trunk
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: