94180 - Grippy appears to the left instead of center (for addressbook and vert 3 pane)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ninoschka Baca]

Build 2001-08-06-03: WinMe
Build 2001-08-06-08: Mac 9.04
haven't tried linux

Overview: When Mail opens the grippy on the horizontal splitter (b/n thread pane
and message pane) appears to the left. This problem occurs with Modern and
Classic themes. 

Actual Results:
- Mac: Modern, Select the grippy and it moves to the center
- Mac: Classic, Select the grippy and it remains to the left
- Win: Modern, Select the grippy and it moves to the center
- Win: Classic, Select the grippy and it moves to the center

Comment 1

[Ninoschka Baca]

Hewitt suggested that I assign this bug to Hyatt.

Comment 2

[sairuh (rarely reading bugmail)]

dave/joe, why is this occurring? just curious. appears to be a recent
regression.

Comment 3

[Jaime Rodriguez, Jr.]

This seems worthy to me. 

David/Petetr - Can we get a nsbranch+? 

Nominating for PDT+ approval.

Comment 4

[selmer (gone)]

Dave, what's the status of this bug?  Are you the right owner?

I wouldn't call this a stop-ship, but if you have a one-liner it would be worth
taking if it shows up RSN.

Comment 5

[David Hyatt]

I think I know what the problem is now.  If I'm right, it will be a one-liner.

Comment 6

[David Hyatt]

Attachment: Holy nonsensical XUL, Batman.

Comment 7

[David Hyatt]

Attributes on the splitter that shouldn't have been there are removed in this 
patch.  It fixes the problem.

Comment 8

[David Hyatt]

Ready for r/sr.

Comment 9

[Brendan Eich [:brendan]]

r=[e-mail], but do we really need a XUL schema, or should old/bad
attributes be diagnosed to the console (or ignored)?

/be

Comment 10

[David Hyatt]

We could start spitting out deprecation warnings, but there would be literally 
hundreds of them during the loading of mailnews or navigator. :)

Comment 11

[Asa Dotzler [:asa]]

0.9.4 is out the door

Comment 12

[Peter Trudelle]

nsbranch+

Comment 13

[Håkan Waara]

I hope it works!  r=hwaara   ;)

Now checkin this baby.

Comment 14

[David Hyatt]

Fixed on branch and trunk.

Comment 15

[R.K.Aa.]

with a current linux CVS build, now *I* for the first time see the grippy to the
far left instead of centered. This is weird.

Comment 16

[R.K.Aa.]

again: this horked alternate threepane. Confirmed on both Linux and Windows:
The splitter that used to be placed in center untill this fix went in, is now to
the far left.

Comment 17

[Ben Ruppel]

I'm using alternate 3-pane, and the grippy hasn't been and still isn't centered
with the September 23 win32 build.  Same with the addressbook.

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 101266 has been marked as a duplicate of this bug. ***

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

From bug 101266, just noting that addressbook ha(s/d) this problem, too.

Comment 20

[R.K.Aa.]

resizing the horisontal splitter makes the grippy "snap" to position. 
(Both mailnews and AB) But it's always to the left on next startup.

Comment 21

[Tracy Walker [:tracy]]

this is  fixed on windows and linux (both trunk and branch)..but it still exists 
on mac and mac osx.

reopening

Comment 22

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix (ignore the code at the top)

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

The fix I attached fixes the addressbook's splitter.

Comment 24

[Jason Kersey]

Comment on attachment 50663 [details] [diff] [review]
Fix (ignore the code at the top)

r=kerz

Comment 25

[David Hyatt]

Comment on attachment 50663 [details] [diff] [review]
Fix (ignore the code at the top)

sr=hyatt

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

I checked in the fix for address book's splitter.

Comment 27

[Ben Ruppel]

This is still broken on 09/25 builds using win32 and the alternate 3-pane.  The
addressbook is fixed though.

Comment 28

[David Hyatt]

Reassigning to component owner to fix their remaining XUL files.

Comment 29

[Håkan Waara]

Attachment: fix for alt-3pane

Comment 30

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 50717 [details] [diff] [review]
fix for alt-3pane

r=stephend

Comment 31

[Jaime Rodriguez, Jr.]

Seth/mscott - We want this one. - PDT

Comment 32

[(not reading, please use [e-mail] instead)]

Comment on attachment 50717 [details] [diff] [review]
fix for alt-3pane

sr=sspitzer

Comment 33

[(not reading, please use [e-mail] instead)]

if I get PDT+, I'll land both the addressbook and the alt 3 pane on the 0.9.4 
branch.

Comment 34

[Håkan Waara]

I landed the alt-3pane fix on the trunk.

Comment 35

[(not reading, please use [e-mail] instead)]

Attachment: here's the patch for the branch

Comment 36

[(not reading, please use [e-mail] instead)]

Comment on attachment 50831 [details] [diff] [review]
here's the patch for the branch

this has been reviewed and super-reviewed, just waiting for pdt

Comment 37

[Jaime Rodriguez, Jr.]

check it in today - PDT+

Comment 38

[(not reading, please use [e-mail] instead)]

fixed on branch and trunk, marking fixed.

Comment 39

[Tracy Walker [:tracy]]

verified fixed on mac commercial builds: 
mac 2001-09-27-03-0.9.4
mac 2001-09-27-04-trunk