Closed
Bug 942334
Opened 11 years ago
Closed 11 years ago
Build hal in unified mode
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
9.58 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8337069 -
Flags: review?(cjones.bugs)
Comment on attachment 8337069 [details] [diff] [review] Build hal in unified mode The code changes look fine to me. I don't know what "unified mode" is, so I'm just rubber-stamping the build changes.
Attachment #8337069 -
Flags: review?(cjones.bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks! FWIW we're switching to unified builds in order to improve our build times, by basically having the build system generate files such as: // Unified_foo.cpp #include "Source1.cpp" #include "Source2.cpp" // ... And compiling them in one go. There is a recent dev.platform thread about this if you're curious.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f60d2a1c4fb
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f60d2a1c4fb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•