942432 - Remove nsIJSEventListener::mContext

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: no_cx_in_jseventlistener.diff

Passing CxPusher to CompileEventHandlerInternal let's us use RePush effectively, so that
in most cases push isn't actually needed.

https://tbpl.mozilla.org/?tree=Try&rev=4568c2f583f3

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Remove unused variable

https://tbpl.mozilla.org/?tree=Try&rev=44a89cac6cd3

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

At some point we should be able to get rid of cxpushing in ELM when handling events, 
since it happens in callback level, but just not in this bug.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3

This should do it, without regressing bug 812744.

https://tbpl.mozilla.org/?tree=Try&rev=87bb7a2a2337

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8337254 [details] [diff] [review]
v3

Er, still some try failures.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v4

Ok, that was just a silly mistake to remove initialization of win variable.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8337392 [details] [diff] [review]
v4

Hah.  The win thing caught me in bug 941876 too.

Speaking of which, this patch will conflict with that bug.  I can merge after you land, I think....

r=me

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/076bf878c59a

Comment 8

[(no longer active)]

Backed out because of build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9849749f3623
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=db836ecd7746

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1efc26dd88

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e1efc26dd88