Closed Bug 942432 Opened 6 years ago Closed 6 years ago
IJSEvent Listener::m Context
Passing CxPusher to CompileEventHandlerInternal let's us use RePush effectively, so that in most cases push isn't actually needed. https://tbpl.mozilla.org/?tree=Try&rev=4568c2f583f3
Remove unused variable https://tbpl.mozilla.org/?tree=Try&rev=44a89cac6cd3
Attachment #8337239 - Attachment is obsolete: true
At some point we should be able to get rid of cxpushing in ELM when handling events, since it happens in callback level, but just not in this bug.
This should do it, without regressing bug 812744. https://tbpl.mozilla.org/?tree=Try&rev=87bb7a2a2337
Comment on attachment 8337254 [details] [diff] [review] v3 Er, still some try failures.
Ok, that was just a silly mistake to remove initialization of win variable.
Comment on attachment 8337392 [details] [diff] [review] v4 Hah. The win thing caught me in bug 941876 too. Speaking of which, this patch will conflict with that bug. I can merge after you land, I think.... r=me
Attachment #8337392 - Flags: review?(bzbarsky) → review+
Backed out because of build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/9849749f3623 https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=db836ecd7746
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.