Closed Bug 942432 Opened 6 years ago Closed 6 years ago

Remove nsIJSEventListener::mContext

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 3 obsolete files)

Attached patch no_cx_in_jseventlistener.diff (obsolete) — Splinter Review
Passing CxPusher to CompileEventHandlerInternal let's us use RePush effectively, so that
in most cases push isn't actually needed.

https://tbpl.mozilla.org/?tree=Try&rev=4568c2f583f3
Attached patch v2 (obsolete) — Splinter Review
Remove unused variable

https://tbpl.mozilla.org/?tree=Try&rev=44a89cac6cd3
Attachment #8337239 - Attachment is obsolete: true
At some point we should be able to get rid of cxpushing in ELM when handling events, 
since it happens in callback level, but just not in this bug.
Attached patch v3 (obsolete) — Splinter Review
This should do it, without regressing bug 812744.

https://tbpl.mozilla.org/?tree=Try&rev=87bb7a2a2337
Attachment #8337244 - Attachment is obsolete: true
Attachment #8337254 - Flags: review?(bzbarsky)
Comment on attachment 8337254 [details] [diff] [review]
v3

Er, still some try failures.
Attachment #8337254 - Flags: review?(bzbarsky)
Attached patch v4Splinter Review
Ok, that was just a silly mistake to remove initialization of win variable.
Attachment #8337254 - Attachment is obsolete: true
Attachment #8337392 - Flags: review?(bzbarsky)
Comment on attachment 8337392 [details] [diff] [review]
v4

Hah.  The win thing caught me in bug 941876 too.

Speaking of which, this patch will conflict with that bug.  I can merge after you land, I think....

r=me
Attachment #8337392 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/8e1efc26dd88
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 944847
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.