Closed Bug 944847 Opened 11 years ago Closed 11 years ago

"Assertion failure: !doc->IsLoadedAsData() (Should not get in here at all)" after adoptNode

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla29

People

(Reporter: jruderman, Assigned: smaug)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(4 files)

testcase
314 bytes, text/html
Details
stack
14.21 KB, text/plain
Details
patch
3.02 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
v2
3.03 KB, patch
Details | Diff | Splinter Review
Attached file testcase — 
Assertion failure: !doc->IsLoadedAsData() (Should not get in here at all), at /Users/jruderman/trees/mozilla-central/content/events/src/nsEventListenerManager.cpp:1346

Regression from bug 942432?
Attached file stack — 

    
    

    
  
The assertion shows an existing bug, or inconsistency.

    
    

    
  
Problem is that the spec doesn't define what should happen in this case
Hixie filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=23956

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
I think we should do this.
Assignee: nobody → bugs

        Attachment #8345372 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 8345372 [details] [diff] [review]
patch

I don't think we should NS_ENSURE_TRUE, with its attendant warning, here.

r=me other than that.

        Attachment #8345372 -
        Flags: review?(bzbarsky) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/65167826b460
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

    
    

    
  
Reproduced on Nightly 2013-11-29-mozilla-central-debug.
Verified fixed on Nightly 29.0a1 2013-12-18-mozilla-central-debug, Win 7 x64.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: