942464 - Recent closed tab history middle click only opens top entry is back in Australis builds

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

This seems to be a recurrance of bug 896986

STR:
1. Click the Menu-panel button
2. click on 'History' Icon
3. Select an entry say mid-list of 'Recent closed tabs', those listed at top of History section since its not marked as such yet.
4. Mid click to open the link
4. Note that the top entry is opened instead.

Win7 x64, latest hourly m-c tinderbox build bases on cset:
https://hg.mozilla.org/mozilla-central/rev/ad6589ed742c

Comment 1

[:Gijs (he/him)]

Does this also happen with the regular menu when you make the menubar show? I suspect so, because that code is now shared, but it'd be an interesting datapoint as to where to look for the bug.

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to :Gijs Kruitbosch from comment #1)
> Does this also happen with the regular menu when you make the menubar show?
> I suspect so, because that code is now shared, but it'd be an interesting
> datapoint as to where to look for the bug.

The Menu-bar works properly 
STR: 
Press Alt - displaying the Menu-bar
Click History 
Highlight and click on Recent Closed tabs
Select a tab to reopen , mid click and it opens properly 

NOTE it does Select the topmost Recent Closed tab as in the STR in Comment #0 if you use the new 'Hamburger' Menu-panel button

Summary:  
Menu bar works properly
Hamburger does not work properly.

Comment 3

[:Gijs (he/him)]

Thanks! I'll have a look ASAP.

Comment 4

[:Gijs (he/him)]

Attachment: make middle-click recently closed tabs work in Australis menu panel, too,

Funny story. Menu items have a .value XBL getter, because it makes sense that menu items have a value. Toolbar buttons don't, because that wouldn't make sense. So the value attribute which we set in the loop is one we should also be getting as an attribute, rather than relying on the item to have a XBL accessor for it.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8337775 [details] [diff] [review]
make middle-click recently closed tabs work in Australis menu panel, too,

Good story! :) The patch lgtm, I just like to be sure that this doesn't introduce nasty side effects; Tim MUST know!

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/0e9b0466f19d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e9b0466f19d