942744 - [Bluetooth] Stop discovering before connecting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Bug 873352 has the same idea as this one. Discovery is a heavy operation which would increase the failure rate of pairing or establishing a new profile level connection. Therefore we should do stopDiscovery() every time before we call pair or connect.

Recently I found that 'restore connection' was usually not successful, and the main reason was that bluedroid(bluetooth backend which will be used after FxOS v1.3) would report that RFCOMM connection couldn't be established. Once I tried to put 'stopDiscovery' in doConnect() before calling defaultAdapter.connect, everything went well. So I'd like to raise this issue again otherwise connection error may happen too often.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/14004

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8337627 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14004

* Reset reviewer to Evelyn after talked to Arthur.

Comment 3

[Evelyn Hung]

Comment on attachment 8337627 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14004

looks good to me. Thanks!

Comment 4

[Evelyn Hung]

merged into gaia master: https://github.com/mozilla-b2g/gaia/commit/e64c724140bbcd582a5ec5bbe5fd5bf253a444ec