94304 - Can't read messages in local folders.

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

Reading mail in local folders is busted, you get an error 80520012 on every
message. This is because of Andreas' checkin for 40670 to nsMailboxService.cpp
to escape the file path in the message load url. I've backed out the escaping
for now. While it may be the right thing to escape the file path, there needs to
be some other change in order to get this to work (probably unescaping somewhere
down the execution path). The two things that are very annoying about this are
that this can not have been tested, and that no one in mail/news was consulted
as reviewer or super-reviewer.

Comment 1

[David :Bienvenu]

fix checked in before 8AM, so respins shouldn't be neccesary.

Comment 2

[Andreas Otte]

I'm very sorry, that stuff slipped in as an attempt to fix bug 93666. That stuff
was never intended for fixing bug 40670. Again sorry, these are the hazards when
 working on more than one bug that deal with the same file. When I got the sr I
forgot to remove that stuff. 

Comment 3

[Andreas Otte]

And to make this more interesting: It does work in my tree, I can acess all
folders in Mailnews with the version of nsMailboxService.cpp that I checked in.
Don't ask me yet why. I don't think I have anything more in my tree than this
change.

Comment 4

[David :Bienvenu]

Andreas, it occurred to me later that you might be running on Linux, or have a
path to your local folders without spaces, so escaping the name won't make any
difference. But on Windows, the paths to local folders always have spaces in them.

Comment 5

[Matthias Versen [:Matti]]

*** Bug 94330 has been marked as a duplicate of this bug. ***

Comment 6

[Matthias Versen [:Matti]]

reopening based on this comment :
"fix checked in before 8AM, so respins shouldn't be neccesary."

The dupe shows that this is 1. not fixed or 2. too late for todays first
builds... 

Please close this bug again if #2.

Comment 7

[Andreas Otte]

Bienvenu: Yes, that's it. I did my tests with bug 93666 on linux.

Comment 8

[Tracy Walker [:tracy]]

I am seeing this on the windows 2001-08-08-07-trunk build from this morning.  
Granrose believes the checking should be picked up on the next build.  I'll 
check that build when it finishes to confirm that this is actually fixed.

Comment 9

[David :Bienvenu]

It looks to me like that build started at 7AM and I checked in at 7:15, judging
from the name of the file : 08-08-07, though I thought builds started at 6AM and
8AM. Anyway, I'm re-resolving fixed.

Comment 10

[Andreas Otte]

Linux also contains spaces in mailbox folder names, still investigating ..

Comment 11

[lohphat]

vierfied fixed on win32 2001080804 14:19 build

Comment 12

[Tracy Walker [:tracy]]

marking verified on windows commercial build 2001-08-09-07-trunk

Comment 13

[David :Bienvenu]

*** Bug 94542 has been marked as a duplicate of this bug. ***