943117 - [B2G][Buri] [Dialer] When we dial out the 2nd call by tapping '+', the call never appears to connect on the phone.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Darren]

Attachment: Logcat

Description:
After calling a second phone, the UI stays on the Dailer keypad screen and does not initially transition to the active call screen.

Repro Steps:
1. Load Buri to Build ID: 20131125142741
2. Open Dialer app
3. Call a phone and have the phone accept the call
4. Tap on the add call icon(Phone with a +)
5. Tap on Keypad button on the bottom right
6. Call another phone

Actual Results:
The screen does not transition and the call never appears to connect on the phone that initiated the call.

Expected Results:
The screen will transition to the active call screen and pause the previous call enabling the user to switch between calls and/or merged the calls.

Environmental Variables
Device: Buri v1.3 MOZ RIL
Build ID: 20131125142741
Gecko: http://hg.mozilla.org/mozilla-central/rev/757c2011df5b
Gaia: bd8053d30c275f8d3040cd494e04b3480a784656
Platform Version: 28.0a1
RIL Version: 01.02.00.019.102
Base Build: 20131115

NOTES:
See attached Log

Comment 1

[Darren]

Attachment: conferencecall.jpg

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 3

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Looks the same as https://bugzilla.mozilla.org/show_bug.cgi?id=933153#c18

Comment 4

[Jason Smith [:jsmith]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> Looks the same as https://bugzilla.mozilla.org/show_bug.cgi?id=933153#c18

How? This issue states that conference calls aren't working at all, while the other bug speaks more towards stopping a conference call.

Comment 5

[Hsin-Yi Tsai (she/her)[:hsinyi]]

This bug is talking about errors happening when user taps on "+" to create a 2nd call. 2nd call is never got connected so that the call isn't in the right state to be merged. That's why it fails to activate a conference call.

Bug 933153 was originally saying there's a problem with ending two calls. However, our investigation shows that is also symptom of an error when creating the 2nd call.

Comment 6

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Providing some investigation when I tested with v1.2_US_20131115.cfg and gecko (github mozillaorg/master) 017ed20347cae2cd892d7ef144e7b36cd44f0185:

There should be a property 'ro.moz.ril.extra_int_2nd_call' set to true on buri. This hardware configuration should have this property added before to fix buri call waiting issue. However, in mozRIL, the value we get is false; that's why mozRIL cannot correctly parse information coming from rild.
 
So some possible causes:
1) the property is somehow changed in base image
2) there's a problem with reading property value by |libcutils.property_get| in mozRIL

B.t.w., buri call waiting is broken as well due to not being able to get the right value of 'ro.moz.ril.extra_int_2nd_call'

Comment 7

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #6)
> Providing some investigation when I tested with v1.2_US_20131115.cfg and
> gecko (github mozillaorg/master) 017ed20347cae2cd892d7ef144e7b36cd44f0185:
> 
> There should be a property 'ro.moz.ril.extra_int_2nd_call' set to true on
> buri. This hardware configuration should have this property added before to
> fix buri call waiting issue. However, in mozRIL, the value we get is false;
> that's why mozRIL cannot correctly parse information coming from rild.
>  
> So some possible causes:
> 1) the property is somehow changed in base image

I don't see the property in
adb shell --> cat /system/build.prop 

> 2) there's a problem with reading property value by |libcutils.property_get|
> in mozRIL
> 
> B.t.w., buri call waiting is broken as well due to not being able to get the
> right value of 'ro.moz.ril.extra_int_2nd_call'

Comment 8

[Sarah Parsons]

This issue started to occur on the Buri 1.2 Build ID: 20131116004001

Gaia   1fb5d3168c95201d90bdb8f3c3d9023f77fffbed
SourceStamp ce9c8493ad98
BuildID 20131116004001
Version 26.0

Last working Buri 1.2 Build ID: 20131115004003

Gaia   a6484b1e6fc07cf6bd8d6fcf9aeebb14b7e8869d
SourceStamp ff2c7c9d01d6
BuildID 20131115004003
Version 26.0

Comment 10

[Hsin-Yi Tsai (she/her)[:hsinyi]]

This isn't the duplicate of bug 933153. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=933153#c26

Comment 11

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Changing the component to Vendcom because we need vendor's help to update image. That said, make sure there's property 'ro.moz.ril.extra_int_2nd_call' set to true on Buri.

Comment 12

[Preeti Raghunath(:Preeti)]

Joe,

This seems specific to base image and need vendor's help here.

Comment 13

[Jason Smith [:jsmith]]

Blocking on this as a vendor issue.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

redirect to vchen on comment 12

Comment 15

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Guoqiang -

Per discussion, for the next 1.2 base image release, please help to add back the property ro.moz.ril.extra_int_2nd_call and set it as true for Buri

Thanks

Comment 16

[Kai-Chih Hu [:khu]]

Because 1.2 is going to be finished, should we mark this bug from koi+ to 1.3+? Thanks.

Comment 17

[Guoqiang.CHEN]

We set ro.moz.ril.extra_int_2nd_call true, and provide new version with it.

Comment 18

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Per comment 17, I believe the issue should be fixed with the latest base image. Ask for QA's help to confirm and close the issue.

Comment 19

[Jason Smith [:jsmith]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #18)
> Per comment 17, I believe the issue should be fixed with the latest base
> image. Ask for QA's help to confirm and close the issue.

Have we confirmed that the new base image is available?

Comment 20

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Jason Smith [:jsmith] from comment #19)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #18)
> > Per comment 17, I believe the issue should be fixed with the latest base
> > image. Ask for QA's help to confirm and close the issue.
> 
> Have we confirmed that the new base image is available?

Yes, US-V1.2-Dev-20131209.cfg is available on Teleweb now.

Comment 21

[Jason Smith [:jsmith]]

Naoki - Can you look into this? Looks like we've got a new base image here, so we should be able to verify this bug.

Comment 22

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified fixed:
nhirata-19333:b2g_buri_master nhirata$ adb shell cat /system/build.prop | grep 'ro.moz.ri'
ro.moz.ril.emergency_by_default=true
ro.moz.ril.extra_int_2nd_call=true
nhirata-19333:b2g_buri_master nhirata$ 

Also tested to make sure that it works... and it does.  UI is a bit funky for this; I will file a separate bug if one isn't already filed.

Comment 23

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia      6415b8b44068596404c10365394544e94edd5ce5
Gecko     http://hg.mozilla.org/mozilla-central/rev/12ea03a70243
BuildID   20131211040203
Version   29.0a1
ro.build.version.incremental=291
ro.build.date=Wed Dec  4 09:48:04 CST 2013
Buri