943276 - Make nsPluginTag::EnsureMembersAreUTF8() not use nsIPlatformCharset

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P5)

Description

[Henri Sivonen (:hsivonen)]

We don't really support non-UTF-8 system encodings on *nix. In order to get rid of nsIPlatformCharset, we should get rid of nsPluginTag::EnsureMembersAreUTF8(), which, AFAICT, only has effect on
 1) OS/2
 2) *nix systems with a non-UTF-8 system encoding configuration.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Do we know what *nix platforms would be affected here?

Comment 2

[Benjamin Smedberg]

This function at least needs to ensure that the strings we get in from plugins are in fact UTF8, and sanitize them if they aren't. We have definitely gotten non-UTF8 strings from Java in the not so distant past, and they were causing aborts.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> This function at least needs to ensure that the strings we get in from
> plugins are in fact UTF8, and sanitize them if they aren't. We have
> definitely gotten non-UTF8 strings from Java in the not so distant past, and
> they were causing aborts.

OK. Morphing the bug summary accordingly. It's probably enough for crash avoidance to check if the strings are valid UTF-8 and, if they are not, performing a conversion from windows-1252 to UTF-8 to get *some* strings that are valid UTF-8.

(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> Do we know what *nix platforms would be affected here?

Not sure. Presumably fringe/legacy configurations of all of them.

Comment 4

[Makoto Kato [:m_kato]]

Since we only support Flash, so we can remove nsIPlatformCharset.  Flash is English version only on Linux.

Comment 5

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.

Comment 6

[Henri Sivonen (:hsivonen)]

Still there:
https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginTags.cpp#477

Comment 7

[Benjamin Smedberg]

The plugins team is never going to work on this bug. Is it really worth keeping it open?

Comment 8

[Henri Sivonen (:hsivonen)]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> The plugins team is never going to work on this bug. Is it really worth
> keeping it open?

Yes, this tracks getting rid of nsIPlatformCharset, so it's worth keeping open until this nsIPlatformCharset use has been removed.

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Remove unused nsIPlatfromCharset

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8884706 [details] [diff] [review]
Remove unused nsIPlatfromCharset

After landing bug 1261841, we don't use nsIPlatformCharset on nsPluginTags.  So we should remove unused header.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4eb026e67d
Remove unused nsIPlatfromCharset. r=emk

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac4eb026e67d