Get rid of nsIPlatformCharset

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: hsivonen, Assigned: m_kato)

Tracking

({meta})

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

See also bug 653031.

Since it  appears that we could on all platforms except OS/2 assume UTF-8  where we currently query for nsIPlatformCharset and users of nsIPlatformCharset typically rely on nsCharsetAlias, which is being superceded by EncodingUtils, let's remove nsIPlatformCharset and let the OS/2 port deal with non-UTF-8 system encodings on the port level without surfacing the issue to cross-platform Gecko code.
Severity: normal → enhancement
Keywords: meta
Depends on: 1351543
Depends on: 1381762
Assignee: nobody → m_kato
Depends on: 1417328
Duplicate of this bug: 653031
all code is removed, so let's remove this interface.
Attachment #8932016 - Flags: review?(jfkthame) → review?(VYV03354)
Comment on attachment 8932016 [details]
Bug 943272 - Get rid of nsIPlatformCharset.

https://reviewboard.mozilla.org/r/203084/#review210006

\o/
Attachment #8932016 - Flags: review?(VYV03354) → review+
Sorry for my lack of response to the initial r? here, Kato-san.... I thought I had reviewed this, but there's clearly no trace of it! I guess I must have killed the window/browser without having hit the right button, or something. :(
https://hg.mozilla.org/mozilla-central/rev/436dbeb1d9b4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.