943272 - Get rid of nsIPlatformCharset

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Henri Sivonen (:hsivonen)]

See also bug 653031.

Since it  appears that we could on all platforms except OS/2 assume UTF-8  where we currently query for nsIPlatformCharset and users of nsIPlatformCharset typically rely on nsCharsetAlias, which is being superceded by EncodingUtils, let's remove nsIPlatformCharset and let the OS/2 port deal with non-UTF-8 system encodings on the port level without surfacing the issue to cross-platform Gecko code.

Comment 2

[Makoto Kato [:m_kato]]

all code is removed, so let's remove this interface.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 943272 - Get rid of nsIPlatformCharset.

Review commit: https://reviewboard.mozilla.org/r/203084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203084/

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8932016 [details]
Bug 943272 - Get rid of nsIPlatformCharset.

https://reviewboard.mozilla.org/r/203084/#review210006

\o/

Comment 5

[Jonathan Kew [:jfkthame]]

Sorry for my lack of response to the initial r? here, Kato-san.... I thought I had reviewed this, but there's clearly no trace of it! I guess I must have killed the window/browser without having hit the right button, or something. :(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/436dbeb1d9b4
Get rid of nsIPlatformCharset. r=emk

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/436dbeb1d9b4