Closed
Bug 943337
Opened 11 years ago
Closed 11 years ago
Merge all 2 kill cards view tests into one.
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: AlinT)
Details
Attachments
(2 files, 1 obsolete file)
Merge: test_cards_view_kill_app.py test_cards_view_kill_app_with_three_apps.py Merge them into one test but using two apps (because using three apps runs into memory problems). This won't compromise test coverage and will reduce test duplication.
|
Reporter | |
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
|
|
Reporter | |
Updated•11 years ago
|
Summary: Merge all 2 kil cards view tests into one. → Merge all 2 kill cards view tests into one.
|
|
Reporter | |
Comment 1•11 years ago
|
||
Make the test case: 1. launch two apps 2. Open cards view 3. kill the two apps 4. Check the "no recent apps" string is present/displayed
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → trifandreialin
|
|
Assignee | |
Comment 2•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(zcampbell)
Attachment #8338540 -
Flags: review?(bob.silverberg)
Attachment #8338540 -
Flags: review?(andrei.hutusoru)
|
||
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(bob.silverberg) → review+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8338540 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14072 Runs nicely but just needs a small tweak in the assertion.
Attachment #8338540 -
Flags: review?(zcampbell) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8339160 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14072 updated according to cr
Attachment #8339160 -
Flags: review?(zcampbell)
Attachment #8339160 -
Flags: review?(florin.strugariu)
Attachment #8339160 -
Flags: review?(bob.silverberg)
Attachment #8339160 -
Flags: review?(andrei.hutusoru)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(andrei.hutusoru)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8339160 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14072 This is the same PR as the other attachment, which is confusing. I am obsoleting this one.
Attachment #8339160 -
Attachment is obsolete: true
Attachment #8339160 -
Flags: review?(zcampbell)
Attachment #8339160 -
Flags: review?(florin.strugariu)
Attachment #8339160 -
Flags: review?(bob.silverberg)
Attachment #8339160 -
Flags: review?(andrei.hutusoru)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(zcampbell)
Attachment #8338540 -
Flags: review?(bob.silverberg)
Attachment #8338540 -
Flags: review-
Attachment #8338540 -
Flags: review+
|
|
Reporter | |
Comment 7•11 years ago
|
||
Comment on attachment 8338540 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14072 LGTM and r+ AlinT! sorry for not spotting the tbpl-manifest earlier. I'll just wait for Travis to be doubley sure.
Attachment #8338540 -
Flags: review?(zcampbell) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(florin.strugariu)
|
|
Reporter | |
Comment 8•11 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/57f03b5e6053cc8021b49dc0babceae6c3cc7e9a
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8338540 -
Flags: review?(florin.strugariu)
Attachment #8338540 -
Flags: review?(bob.silverberg)
|
|
Assignee | |
Comment 9•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 10•11 years ago
|
||
Comment on attachment 8340280 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14210 uplift to v1.2
Attachment #8340280 -
Flags: review?(zcampbell)
Attachment #8340280 -
Flags: review?(viorela.ioia)
Attachment #8340280 -
Flags: review?(florin.strugariu)
Attachment #8340280 -
Flags: review?(bob.silverberg)
Attachment #8340280 -
Flags: review?(andrei.hutusoru)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8340280 -
Flags: review?(zcampbell)
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8340280 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14210 Good PR, but it's missing the promised TODO. :)
Attachment #8340280 -
Flags: review?(bob.silverberg) → review-
|
|
Assignee | |
Comment 12•11 years ago
|
||
I've commented in pr also, but I'll leave a comment here also. For the TODO is was talking about i logged bug 944637, which is Resolved Wontfix and the "No recent apps" message will not land in v1.2
|
||
Updated•11 years ago
|
Attachment #8340280 -
Flags: review?(florin.strugariu) → review+
|
||
Updated•11 years ago
|
Attachment #8340280 -
Flags: review?(viorela.ioia) → review+
|
|
||
Comment 13•11 years ago
|
||
Comment on attachment 8340280 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14210 Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/e226f3d156489ea998049380e7d69bc5ed0b2dbd
Attachment #8340280 -
Flags: review?(andrei.hutusoru)
Attachment #8340280 -
Flags: review-
Attachment #8340280 -
Flags: review+
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 14•11 years ago
|
||
typo patch to v1.3 too https://github.com/mozilla-b2g/gaia/commit/35ae5c8a53c48ecac3e93e9843c8465d971d79a7
You need to log in
before you can comment on or make changes to this bug.
Description
•