943391 - nsPipe3.cpp(302) : warning C4355: 'this' : used in base member initializer list

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Build warnings:
{
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\xpcom\io\nsPipe3.cpp(302) : warning C4355: 'this' : used in base member initializer list
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\xpcom\io\nsPipe3.cpp(303) : warning C4355: 'this' : used in base member initializer list
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=31083482&tree=Try

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

RE whether this is safe:

mInput is of type nsPipeInputStream, and its constructor simply saves a pointer to the pipe -- it doesn't dereference it.
http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#108

mOutput is of type nsPipeOutputStream, and the same is true of it. (no dereferencing in the constructor)
http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#165

So, the "this" usage is safe, and MOZ_THIS_IN_INITIALIZER_LIST is appropriate.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f57d2519a47

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9f57d2519a47