Closed
Bug 943238
Opened 11 years ago
Closed 11 years ago
Mark xpcom/io as FAIL_ON_WARNINGS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
602 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
On my system, with bug 942400 and bug 943235 applied to mozilla-inbound, /xpcom/io is warning-free and can be labeled FAIL_ON_WARNINGS.
Filing this bug on making it so.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8338311 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8338311 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Filed bug 943391 on the remaining windows warning (causing the red windows builds in comment 2).
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try run with that bug fixed as well: https://tbpl.mozilla.org/?tree=Try&rev=23226c187b71
|
|
Assignee | |
Comment 5•11 years ago
|
||
Try run from Comment 4 is green on Windows (and the run from Comment 2 covers all the other platforms), so I landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea043d71b3c6
Flags: in-testsuite-
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•