Closed Bug 943238 Opened 6 years ago Closed 6 years ago

Mark xpcom/io as FAIL_ON_WARNINGS

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

On my system, with bug 942400 and bug 943235 applied to mozilla-inbound, /xpcom/io is warning-free and can be labeled FAIL_ON_WARNINGS.

Filing this bug on making it so.
Attached patch fixSplinter Review
Attachment #8338311 - Flags: review?(nfroyd)
Attachment #8338311 - Flags: review?(nfroyd) → review+
Depends on: 943391
Filed bug 943391 on the remaining windows warning (causing the red windows builds in comment 2).
Try run with that bug fixed as well: https://tbpl.mozilla.org/?tree=Try&rev=23226c187b71
Try run from Comment 4 is green on Windows (and the run from Comment 2 covers all the other platforms), so I landed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/ea043d71b3c6
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/ea043d71b3c6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.