Closed Bug 943449 Opened 6 years ago Closed 6 years ago

Consistent dump() methods for Ion objects

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: sunfish, Assigned: sunfish)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch dump.patchSplinter Review
Following bug 883570, there are still a variety of ways to dump data structures when debugging Ion -- print(stderr), toString(), dump(stderr) and others. Attached is a patch which introduces a new idiom, which is to have plain dump() methods on classes.

dump() is more convenient than dump(stderr), and it's more familiar to people with LLVM experience, where dump() is a common idiom.

If this patch is accepted, I'll also update

https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips

to describe the new idiom.
Attachment #8338606 - Flags: review?(nicolas.b.pierron)
Attachment #8338606 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/4b627d104594
https://hg.mozilla.org/mozilla-central/rev/d822990ba9ee
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.