Created attachment 8338606 [details] [diff] [review] dump.patch Following bug 883570, there are still a variety of ways to dump data structures when debugging Ion -- print(stderr), toString(), dump(stderr) and others. Attached is a patch which introduces a new idiom, which is to have plain dump() methods on classes. dump() is more convenient than dump(stderr), and it's more familiar to people with LLVM experience, where dump() is a common idiom. If this patch is accepted, I'll also update https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips to describe the new idiom.
Attachment #8338606 - Flags: review?(nicolas.b.pierron)
Attachment #8338606 - Flags: review?(nicolas.b.pierron) → review+
And a follow-up to make the style checker happy. https://hg.mozilla.org/integration/mozilla-inbound/rev/d822990ba9ee https://tbpl.mozilla.org/php/getParsedLog.php?id=31108332&tree=Mozilla-Inbound
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.