Consistent dump() methods for Ion objects

RESOLVED FIXED in mozilla28

Status

()

--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sunfish, Assigned: sunfish)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 8338606 [details] [diff] [review]
dump.patch

Following bug 883570, there are still a variety of ways to dump data structures when debugging Ion -- print(stderr), toString(), dump(stderr) and others. Attached is a patch which introduces a new idiom, which is to have plain dump() methods on classes.

dump() is more convenient than dump(stderr), and it's more familiar to people with LLVM experience, where dump() is a common idiom.

If this patch is accepted, I'll also update

https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips

to describe the new idiom.
Attachment #8338606 - Flags: review?(nicolas.b.pierron)
Attachment #8338606 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/4b627d104594
https://hg.mozilla.org/mozilla-central/rev/d822990ba9ee
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.