943713 - Please install dbus-x11 on Linux build machines

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Nicholas Nethercote [inactive]]

In bug 940069 we determined that the lack of the dbus-launcher program on Linux build machines was resulting (through a non-trivial sequence of events) in Valgrind giving lots of false positive leak reports.

karlt thinks fixing this might be as simple as installed dbus-x11 on the build machines.  See bug 940069 comment 42.

Comment 1

[[e-mail] (:bhearsum)]

Just to be certain, we're talking about jobs like https://tbpl.mozilla.org/php/getParsedLog.php?id=30758937&tree=Mozilla-Central, right?

Comment 2

[[e-mail] (:bhearsum)]

Attachment: install dbus-x11 for valgrind nightlies

If my assumption in comment #1 is true, this should be all we need.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8339272 [details] [diff] [review]
install dbus-x11 for valgrind nightlies

Please let me know if this is required for builds other than "Linux x86-64 mozilla-central valgrind".

Comment 4

[John Hopkins (:jhopkins)]

in production

Comment 5

[Nicholas Nethercote [inactive]]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Just to be certain, we're talking about jobs like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=30758937&tree=Mozilla-
> Central, right?

Yes!  Thanks for the quick response.

These run daily at 3am PST... but could somebody from releng please trigger an extra run so we can tell earlier if this has fixed the problem?  Thanks!

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> (In reply to Ben Hearsum [:bhearsum] from comment #1)
> > Just to be certain, we're talking about jobs like
> > https://tbpl.mozilla.org/php/getParsedLog.php?id=30758937&tree=Mozilla-
> > Central, right?
> 
> Yes!  Thanks for the quick response.
> 
> These run daily at 3am PST... but could somebody from releng please trigger
> an extra run so we can tell earlier if this has fixed the problem?  Thanks!

Done. FYI: you can also do this yourself by selecting the job on TBPL and clicking the "+" button in corner of the frame in the bottom left.

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> Done. FYI: you can also do this yourself by selecting the job on TBPL and
> clicking the "+" button in corner of the frame in the bottom left.

Not necessarily the case for non-nightly builds of Valgrind, see bug 793989.

Comment 8

[Nicholas Nethercote [inactive]]

It worked! :)