944079 - [Australis] Remove one of the two hover states of items in the bookmarks panel

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: different hover states

Items in the bookmark list panel (next to the star icon) have two different hover states. We should reduce that to only one state that gets triggered immediately. My vote goes for the second state (see attached image) because it is visually less busy.

Comment 1

[Stephen Horlander [:shorlander]]

Comment on attachment 8339490 [details]
different hover states

We are doing a weird thing where we have a hover state and an active state. We really just need a hover state. Also no inverted arrows.

I put the intended behavior in the latest interactive mockup: https://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I see the two different styles on Windows also.

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

With shorlanders mockup as a reference, here's what needs to be done:
1) Remove the fading of the hover state, so that the menu feels more responsive
2) Get rid of the secondary hover state (when long-hovering over a folder)
3) Get rid of the white arrows that flash through at the moment

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

1 and 3 appear to be Mac only by the way.

Comment 5

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] from comment #3)
> With shorlanders mockup as a reference, here's what needs to be done:
> 1) Remove the fading of the hover state, so that the menu feels more
> responsive

The fading is the same across all of the subviews and the panel menu. Do you really want it removed *just* for the bookmarks menu? Everywhere? Neither?

Comment 6

[:Gijs (he/him)]

Attachment: remove double hover state in bookmarks menu,

This does everything except adjusting the fade, awaiting ux decision on that one.

Comment 7

[Matthew N. [:MattN]]

You realize this is currently a P-, right? ;)

Comment 8

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] from comment #7)
> You realize this is currently a P-, right? ;)

It blocks the P2 "bookmarks panel polish" bug, and is on the UX blocker list, though...

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #6)
> Created attachment 8382584 [details] [diff] [review]
> remove double hover state in bookmarks menu,
> 
> This does everything except adjusting the fade, awaiting ux decision on that
> one.

Tested it and it's looking good!
I think we can keep it that way!

Comment 10

[:Gijs (he/him)]

Alright!

remote:   https://hg.mozilla.org/integration/fx-team/rev/67913237769c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67913237769c

Comment 12

[Tim Nguyen :ntim]

(In reply to Philipp Sackl [:phlsa] from comment #4)
> 1 and 3 appear to be Mac only by the way.

Windows XP also has the white arrow on hover. Note sure if it's important to support XP though, as XP is gonna get unsupported soon.

Comment 13

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #12)
> (In reply to Philipp Sackl [:phlsa] from comment #4)
> > 1 and 3 appear to be Mac only by the way.
> 
> Windows XP also has the white arrow on hover. Note sure if it's important to
> support XP though, as XP is gonna get unsupported soon.

Please file a new bug for this.

Comment 14

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Tim Nguyen [:ntim] from comment #12)
> (In reply to Philipp Sackl [:phlsa] from comment #4)
> > 1 and 3 appear to be Mac only by the way.
> 
> Windows XP also has the white arrow on hover. Note sure if it's important to
> support XP though, as XP is gonna get unsupported soon.

AFAIK a large number of Firefox Users still use XP. Unless we see that number go down significantly after the discontinuation by Microsoft, it makes sense to keep supporting it well.

Comment 15

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #13)
> (In reply to Tim Nguyen [:ntim] from comment #12)
> > (In reply to Philipp Sackl [:phlsa] from comment #4)
> > > 1 and 3 appear to be Mac only by the way.
> > 
> > Windows XP also has the white arrow on hover. Note sure if it's important to
> > support XP though, as XP is gonna get unsupported soon.
> 
> Please file a new bug for this.

Filed bug 978309.

Comment 16

[:Gijs (he/him)]

Comment on attachment 8382584 [details] [diff] [review]
remove double hover state in bookmarks menu,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: bookmark panel has strange hover/active states
Testing completed (on m-c, etc.): on m-c for a long time now
Risk to taking this patch (and alternatives if risky): low. Known issue (bug 978309) but that was likely an issue before, and we should be able to fix it in time for 29's release. Additionally, a bunch of the remaining panel polish depends on this landing, so I think we should uplift now to avoid keeping back a bunch of bugs until the last moment.
String or IDL/UUID changes made by this patch: none

Comment 17

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fb451046022f