963098 - [meta] Polish the bookmarks subview and panel

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[u428464]

The bookmarks widget subview and panel could be a bit enhanced.

The Win 8 mockup http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html for example adds a footer with "Show all bookmarks" for consistency with the history view. It should be the same in the subview.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Unless the contents get limited by a lot (as in the screenshot), I disagree with moving one of the most useful options to the bottom. But then limiting contents would make it less useful. This is quite different from the 15 items history menu. It would be good if the menu would only show the last 15 bookmarks.

Comment 2

[Tim Nguyen :ntim]

(In reply to Marco Bonardo [:mak] from comment #1)
> Unless the contents get limited by a lot (as in the screenshot), I disagree
> with moving one of the most useful options to the bottom. But then limiting
> contents would make it less useful. This is quite different from the 15
> items history menu. It would be good if the menu would only show the last 15
> bookmarks.

Or maybe use an arrow scroll box after 15 bookmarks.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

well, there is already a scrollbox, but the menu height is only limited by the screen.... Moreover I think UX wants to remove arrow scrollboxes in panels and use normal scrollbars... but yes, the idea is that unless the menu is somehow limited it's not a good idea to move stuff to the bottom.

Comment 4

[Madhava Enros [:madhava]]

I have a list here from Shorlander, about which he is going to provide some clarifying specs/mockups:

* Panel can become too wide
* Font size between panels is inconsistent: http://cl.ly/image/233Z343Y1m1A
* Looks like there is a transition on the item hover state, makes it feel hanky
  * possibly related to: 944079 [P4]
* Opening submenus is slow, also has an unnecessary (and slow) secondary active state
* Submenus are visually inconsistent with the panel
* No checkmark for the active “View Bookmarks Toolbar” item
* Padding is inconsistent with other Panels
* Wrong checkmark on OS X

Comment 6

[:Gijs (he/him)]

(In reply to Madhava Enros [:madhava] from comment #4)
> I have a list here from Shorlander, about which he is going to provide some
> clarifying specs/mockups:
> 
> * Panel can become too wide
> * Font size between panels is inconsistent: http://cl.ly/image/233Z343Y1m1A

The design actually specified different font sizes between the main panel and subviews (in particular, 12px font in the subview, as opposed to the now-default 11px font in the main panel), and that's one of the things that item highlights. I questioned it in the review for bug 878546, but as the design said this, that's what we implemented. Are we basically supposed to be reverting this? Why was (is, at time of writing!) this in the design?

As for the submenus from the bookmarks panel, I thought we made the decision to style them natively as menus (bug 900162)? That implies we don't control font size, the user's OS preference settings do, and they can (and in most cases will) be different from the same preferences that currently underlie the font size in the main panel. I've just duped bug 963704 here seeing as this is where discussion seems to be happening.

What is the desired outcome here, as far as the font size and visual inconsistency between bookmarks panel and its submenus is concerned?

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I broke this bug into a couple of smaller ones. Gijs, the information you asked about should be in bug 969584.

There are a few things I couldn't reproduce though:

> * Panel can become too wide
It doesn't look too wide to me, even with a very long bookmark title in there

> * No checkmark for the active “View Bookmarks Toolbar” item
I couldn't reproduce this

> * Wrong checkmark on OS X
Is there a glyph for the right checkmark somewhere?

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Stephen, could you clarify the remaining points from comment 8 and/or link the bugs about those issues?

Comment 10

[Stephen Horlander [:shorlander]]

(In reply to Philipp Sackl [:phlsa] from comment #8)
> I broke this bug into a couple of smaller ones. Gijs, the information you
> asked about should be in bug 969584.
> 
> There are a few things I couldn't reproduce though:
> 
> > * Panel can become too wide
> It doesn't look too wide to me, even with a very long bookmark title in there

It feels pretty gigantic too me :) It is significantly wider than all of our other panels, notably also much wider than History, DevTools or Character Encoding. Feels unwieldy and chunky.


> > * No checkmark for the active “View Bookmarks Toolbar” item
> I couldn't reproduce this

Seeing it in the latest Nightly. Blake said he was working on it.

> > * Wrong checkmark on OS X
> Is there a glyph for the right checkmark somewhere?

For OS X we use http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/menu/menu-check.png

I think we are pulling the Windows system checkmark in normal menus.

Comment 11

[Tim Nguyen :ntim]

> I think we are pulling the Windows system checkmark in normal menus.
Yeah, but Panel UI menus are not "normal" menus. They use the unicode character shown in the screenshot.

Here's the glyph for Windows : http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/images-win8/menuItem-icon-checkmark.png

Comment 12

[u428464]

This is resolved. \o/

Comment 13

[Marc Auslander]

Folders in the Bookmark Toolbar still use the OS menu appearance, which seems inconsistent.

Comment 14

[:Gijs (he/him)]

(In reply to Marc Auslander from comment #13)
> Folders in the Bookmark Toolbar still use the OS menu appearance, which
> seems inconsistent.

They don't for me. Please file a followup bug with more details, like which specific OS you're testing on, and which build you're testing, and whether you mean the menu items that open up the folder, or the contents of the folder (ie submenus) and to what extent they "use the OS menu appearance". Screenshots would help, too.

Comment 15

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I *think* he means the menus opening from the actual bookmarks toolbar (not through the panel), which do use OS styling. I don't believe there was a design decision on that yet, but it would definitely be a different bug.

Comment 16

[Marc Auslander]

Opened https://bugzilla.mozilla.org/show_bug.cgi?id=984343