944126 - Random failures with browser_privatebrowsing_aboutSessionRestore.js

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: pb_test2_failure.diff

Rather similar to Bug 938030

Comment 1

[(no longer active)]

Comment on attachment 8339543 [details] [diff] [review]
pb_test2_failure.diff

Review of attachment 8339543 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_aboutSessionRestore.js
@@ +18,5 @@
>          win.gBrowser.selectedTab = newTab;
>          let tabBrowser = win.gBrowser.getBrowserForTab(newTab);
>          tabBrowser.addEventListener("load", function tabLoadListener() {
> +          if (win.gBrowser.contentWindow.location != "about:sessionrestore") {
> +            win.gBrowser.selectedBrowser.loadURI("about:sessionrestore");

I think you forgot a return here.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

bah, did I attach some wrong patch.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: with return

https://tbpl.mozilla.org/?tree=Try&rev=4a5614d8a8f1

(The tryserver run may have other failures which I'm investigating)

Comment 4

[(no longer active)]

Comment on attachment 8339594 [details] [diff] [review]
with return

Review of attachment 8339594 [details] [diff] [review]:
-----------------------------------------------------------------

I think the loadURI call is redundant, please verify that it's needed.  r=me either way.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_aboutSessionRestore.js
@@ +18,5 @@
>          win.gBrowser.selectedTab = newTab;
>          let tabBrowser = win.gBrowser.getBrowserForTab(newTab);
>          tabBrowser.addEventListener("load", function tabLoadListener() {
> +          if (win.gBrowser.contentWindow.location != "about:sessionrestore") {
> +            win.gBrowser.selectedBrowser.loadURI("about:sessionrestore");

Hmm, why do you need to load the URL again here?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

IIRC this was again (test) PAC loading lately, so we may get wrong load.

Comment 6

[(no longer active)]

(In reply to comment #5)
> IIRC this was again (test) PAC loading lately, so we may get wrong load.

PAC?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8b520e0aa0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb8b520e0aa0

Comment 9

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f4b4417d125
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e52eb86c3c02
https://hg.mozilla.org/releases/mozilla-esr24/rev/4d510f461923