Closed Bug 944141 Opened 12 years ago Closed 12 years ago

Valgrind-on-TBPL: Remove unnecessary suppressions

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: [qa-])

Once Valgrind is reporting no errors on TBPL (bug 944133) it would be good to temporarily remove all the suppressions for unintentinal leaks within our code to see which ones are still present. (I won't bother removing suppressions for third-party code and intentional leaks, however.)
Summary: Valgrind-on-TBPL: Suppress an intentional leak → Valgrind-on-TBPL: Remove unnecessary leak suppressions
There's a memcheck:free suppression that we should try removing as well: https://hg.mozilla.org/mozilla-central/annotate/default/build/valgrind/cross-architecture.sup#l211 Ditto the suppression for bug 850134, in the files i386-redhat-linux-gnu.sup and x86_64-redhat-linux-gnu.sup. (It's the only one for the js engine there, and I think I put it there because it was Linux-only.) https://hg.mozilla.org/mozilla-central/annotate/5eb1c89fc2bc/build/valgrind/i386-redhat-linux-gnu.sup#l54 https://hg.mozilla.org/mozilla-central/annotate/5eb1c89fc2bc/build/valgrind/x86_64-redhat-linux-gnu.sup#l53 Once we tidy the list of known leaks, we are likely another step towards Valgrind-on-every-checkin. \o/
I pushed a patch that disables all the relevant suppressions: https://hg.mozilla.org/mozilla-central/rev/a5e7f611546f Let's see how it goes and then proceed from there.
I pushed another patch that removes all the unnecessary suppressions. https://hg.mozilla.org/mozilla-central/rev/7f14d602e0c5 If I've done things correctly, we only have four unintentional leaks reported in Mozilla code. Cool.
Summary: Valgrind-on-TBPL: Remove unnecessary leak suppressions → Valgrind-on-TBPL: Remove unnecessary suppressions
> four unintentional leaks reported in Mozilla code. And all of them in XPCOM component management, interestingly enough.
bhearsum triggered a run with the minimized suppression files and we have no errors: https://tbpl.mozilla.org/php/getParsedLog.php?id=31223163&tree=Mozilla-Central&full=1 Woo!
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: valgrind-on-tbpl
No longer blocks: valgrind-tbpl-bugs
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.