Keyboard should not fire inputcontextchange on every mouseup event

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: janjongboom, Assigned: janjongboom)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

At the moment we fire Forms:Input event from forms.js on every mouseup. That is not correct as we have a separate event to update the selection range already.
Created attachment 8340347 [details] [diff] [review]
944681.patch

Need to have this fixed for cursor positioning.
Assignee: nobody → janjongboom
Attachment #8340347 - Flags: review?(xyuan)
(Assignee)

Updated

4 years ago
Blocks: 921964
Comment on attachment 8340347 [details] [diff] [review]
944681.patch

Review of attachment 8340347 [details] [diff] [review]:
-----------------------------------------------------------------

r=+ if someone can fix gaia keyboard bug after apply this gecko patch.

The gaia keyboard doesn't listen to the selection change or surroundingtextchange event. If gecko doesn't fire inputcontextchange event when user moves the cursor, the keyboard doesn't know the cursor position is changed and the auto-correction will be wrong.
Attachment #8340347 - Flags: review?(xyuan) → review+
I'll write a patch.
I don't think this is correct, I checked with this patch and the autocorrect still works, because the gaia keyboard doesn't use any of the events at the moment but keeps state internally.

Rudy, can you confirm?
Flags: needinfo?(rlu)
Yes, I think right now the buit-in keyboard does not listen to selectionchange or surroundingtextchange and would keep the state internally.
Flags: needinfo?(rlu)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/578b2f1504d8

Jan, the name on your patches still isn't importing into hg correctly.
Keywords: checkin-needed
Yeah, sorry, this was still an old style patch. Thanks for landing.
https://hg.mozilla.org/mozilla-central/rev/578b2f1504d8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Blocks: 1023688
You need to log in before you can comment on or make changes to this bug.