944920 - NSPR autoconf support for aarch64 needed for fedora

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Elio Maldonado]

As reported in Fedora:

 Dennis Gilmore 2013-03-23 11:37:06 EDT

Support for the ARM 64 bit CPU architecture (aarch64) was introduced in 
autoconf 2.69.  nspr appears to use an earlier version of 
autoconf, preventing its being built.  This can be fixed in of three ways (In order of preference):

1. Work with upstream to migrate the package to autoconf 2.69.

2. Rerun autoconf or autoreconf in %prep or %build prior to running 
configure.

3. Apply the patch at http://ausil.fedorapeople.org/aarch64/nspr/nspr-aarch64.patch
which updates config.guess and config.sub to recognize aarch64.

[reply] [−]
Comment 1 Marcin Juszkiewicz 2013-11-27 04:29:05 EST

With nspr 4.10.2 only gnu-config update is needed.

Comment 1

[Elio Maldonado]

I don't have a patch yet and there is some work on Fedora where by changes in the spec file this may be solved. Stay tuned until I find more information.

Comment 2

[Marcin Juszkiewicz]

There are other distributions and build systems which also have to deal with outdated config.{guess,sub} files.

Update to those files would also help people porting for ppc64le.

Comment 3

[(not currently active) Ted Mielczarek]

NSPR is not going to update to a newer autoconf, but updating config.{guess,sub} sounds fine.

Comment 4

[Marcin Juszkiewicz]

Especially when current copies of config.{guess,sub} are over 8 years old...

Comment 5

[Marcin Juszkiewicz]

Attachment: mozilla-944920-gnu-config.patch

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8378213 [details] [diff] [review]
mozilla-944920-gnu-config.patch

Review of attachment 8378213 [details] [diff] [review]:
-----------------------------------------------------------------

You've updated every config.{sub,guess} in the tree, which is not what we want to do. Many of these are from third-party projects, which means that when we pull a new update from upstream the changes will be lost. Additionally, we don't even run all of these configure scripts, so updating them is not necessary.

Of the ones you've got in this patch, you'll need to submit upstream patches to icu, libffi, jemalloc, freetype2. I'm okay with you patching them locally in our tree for now until we get an updated version, but if you want your fix to stick you'll need to do that.

We don't run the configure script in the libevent directory or the google-breakpad directory, so you can drop those from the patch.

NSPR is effectively an upstream project, but I can land the update patch there for you.

Comment 7

[Wan-Teh Chang]

Comment on attachment 8378213 [details] [diff] [review]
mozilla-944920-gnu-config.patch

Review of attachment 8378213 [details] [diff] [review]:
-----------------------------------------------------------------

Marcin,

Thanks a lot for the patch.

I only reviewed the changes to NSPR's config.guess and config.sub
in this patch. I verified that they are the unmodified config.guess
and config.sub scripts from upstream GNU config. So they don't have
our local modifications to the scripts.

I am updating NSPR's config.guess and config.sub in bug 695993,
which will take care of aarch64 support.

Comment 8

[Wan-Teh Chang]

I verified that the patch at
    http://ausil.fedorapeople.org/aarch64/nspr/nspr-aarch64.patch
that Elio mentioned in comment 0 also uses unmodified config.guess
and config.sub scripts from upstream GNU config, so it is also
missing our local modifications to the scripts.

Comment 9

[Wan-Teh Chang]

Fixed by the patch in bug 695993:
https://hg.mozilla.org/projects/nspr/rev/c8b3d4100698