962534 - Add AArch64 support

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Marcin Juszkiewicz]

Attachment: aarch64-support.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140116030250

Steps to reproduce:

Xulrunner does not support AArch64 (64-bit ARM) now. There are missing cpu defines etc.

Attached patch and few other bugs add such support.

Comment 1

[Nathan Froyd [:froydnj]]

Marcin, thanks for the patch!

It's probably easier if you break the patch up into chunks and file bugs separately for each chunk.  You'll probably want to split the patch along directory lines, so you'd have a patch for each of these directories, along with the product :: component that you'd file a bug for them in:

- xpcom/ (in Core :: XPCOM)
- js/src/assembler/ (in Core :: JavaScript Engine)
- media/ (in Core :: WebRTC)
- memory/ (in Core :: jemalloc)
- mfbt/ (in Core :: MFBT)
- ipc/ (in Core :: IPC)
- gfx/ (in Core :: Graphics)
- The configure.in and js/src/configure.in change would go together as a separate patch. (in Core :: Build Config)

I can review the changes in xpcom/, memory/, and mfbt/ (and you'll probably want to add aarch64 cases in mfbt/Endian.h as well).  :glandium can review the changes to the configure.in files.

The next two have their own special requirements, since nsprpub is its own project and toolkit/crashreporter comes from upstream.  Definitely worth filing separate bugs for each of them:

- nsprpub/ (in NSPR :: NSPR)
- toolkit/ (in Toolkit :: Breakpad Integration)

Please let me know if you need any help, or come find froydnj on #developers on irc.mozilla.org.  Thanks for doing this work!

Comment 2

[Marcin Juszkiewicz]

Attached patch got split and added as set of bugs. All AArch64 specific bugs added as dependencies for this one.

Comment 3

[(not currently active) Ted Mielczarek]

Marcin: I gave your bugzilla account editbugs, so you should be able to assign bugs to yourself and tweak other fields.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Marcin, is there more work that needs to be done or can this bug be closed now?

Comment 5

[Marcin Juszkiewicz]

I will do build of current trunk today but all needed changes were merged so it should work now out of the box.

Will reopen if there will be new issues.