Closed Bug 945045 Opened 6 years ago Closed 6 years ago

Remove nsISupportsArray in mailnews/import

Categories

(MailNews Core :: Import, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: hiro, Assigned: hiro)

References

Details

(Whiteboard: [external-api-bustage])

Attachments

(2 files, 1 obsolete file)

No description provided.
Attached patch A patch (obsolete) — Splinter Review
This patch does not remove all nsISupportsArray in mailnews/import.

The rest part of nsISupportsArray usage are:

1. In nsEudoraFilters::AddTerm
 to use nsIMsgFilter.searchTerm.
 
2. In nsProxySendRunnable::Run in nsImportService.cpp
 to use nsIMsgSend.createRFC822Message

Those usage should be fixed when thoese interfaces will be changed.
Attachment #8340815 - Flags: review?(mbanner)
Cool!
Comment on attachment 8340815 [details] [diff] [review]
A patch

Review of attachment 8340815 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks for this. r=Standard8 with the nits fixed.

::: mailnews/import/public/nsIImportAddressBooks.idl
@@ +84,4 @@
>      address book.  The array is not sorted before display to the user.
>      location is null if GetAutoFind returned true.
>    */
> +  nsIArray FindAddressBooks( in nsIFile location);

nit: can you remove the space after ( please.

::: mailnews/import/public/nsIImportMail.idl
@@ +59,3 @@
>      mailbox.  The array is not sorted before display to the user.
>    */
> +  nsIArray FindMailboxes( in nsIFile location);

nit: can you remove the space after ( please.

::: mailnews/import/src/nsImportMail.cpp
@@ +97,5 @@
>    bool          m_gotLocation;
>    bool          m_found;
>    bool          m_userVerify;
>    nsIImportMail *    m_pInterface;
> +  nsIArray *  m_pMailboxes;

nit: can you remove the space after * please.

@@ +117,5 @@
>    uint32_t        currentTotal;
>    uint32_t        currentSize;
>    nsIMsgFolder *      destRoot;
>    bool            ownsDestRoot;
> +  nsIArray *    boxes;

nit: can you remove the spaces after * please.
Attachment #8340815 - Flags: review?(mbanner) → review+
Attached patch Revised patchSplinter Review
carrying over review+.
Assignee: nobody → hiikezoe
Attachment #8340815 - Attachment is obsolete: true
Attachment #8355925 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/117ad84fb83e
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Comment on attachment 8355925 [details] [diff] [review]
Revised patch

This broke external API builds for two reasons:
* You used NS_NewISupportsArray in nsImportService.cpp without including nsMsgUtils.h which contains an external-API-safe declaration of it
* You removed the include of nsISupportsArray.h from nsOEScanBoxes.h which happens to be what was including nsCOMPtr.h in external API builds
(I don't know how nsCOMPtr.h gets included in normal builds.)
Attachment #8358716 - Flags: review?(mbanner)
Whiteboard: [external-api-bustage]
Attachment #8358716 - Flags: review?(mbanner) → review+
Depends on: 1042294
Depends on: 1326494
You need to log in before you can comment on or make changes to this bug.