945472 - [Call Log] Implement position:sticky for fixed headers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Kevin Grandon :kgrandon]

We should migrate our Fixed Header javascript to the new position: sticky CSS position.

This is also necessary for smooth headers when APZ is turned on.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull request - Use position:sticky for fixed headers

Comment 2

[Kevin Grandon :kgrandon]

Already blocks 943849, so cleaning up the dependency chain.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8341316 [details] [review]
Pull request - Use position:sticky for fixed headers

Hey Anthony - being that you CC'd yourself here, I was wondering if you would be willing to review this bug?

We are not ready to land this yet until APZ and position sticky is turned on, but we want to have patches reviewed and ready to go. Let me know if you have any concerns here. Thanks!

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8341316 [details] [review]
Pull request - Use position:sticky for fixed headers

I cced myself cause I was supposed to work on it yesterday but I had a good surprise when waking up :)

I've taken a look at the patch and it looks sensible. I don't have enough experience on the call log to feel like reviewing this though. Maybe we can even remove more logic.

And f*** yeah for better performance and less code \o/

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8341316 [details] [review]
Pull request - Use position:sticky for fixed headers

This looks great to me, Kevin! Thanks! I would also like to hear Etienne's feedback here though.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8341316 [details] [review]
Pull request - Use position:sticky for fixed headers

Sweet!

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Kevin can we land that once bug 945777 has landed ?

Comment 8

[Kevin Grandon :kgrandon]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #7)
> Kevin can we land that once bug 945777 has landed ?

Absolutely. My preference would be to shore up one or two of the blocking position sticky bugs before turning it on in gaia. Maybe we can work on this in Paris in the next few weeks.

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/86551a74a23bcb7f5e0ffe48a09ef03843d652ca

Comment 10

[Mike Lee [:mlee]]

1.3+, blocked existing 1.3 blocker Bug 943849 via Bug 942460.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.3.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.3, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.3
  git cherry-pick -x -m1 86551a74a23bcb7f5e0ffe48a09ef03843d652ca
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Does this still need uplift to v1.3?

Comment 13

[Kevin Grandon :kgrandon]

Looks like it. Sorry, I missed the comment and didn't have a ni? here. I'll uplift now.

Comment 14

[Kevin Grandon :kgrandon]

Landed in v1.3: https://github.com/mozilla-b2g/gaia/commit/72960310a1a9842a9fe442c7e46c77f2485d422f