Closed Bug 916315 Opened 6 years ago Closed 6 years ago

enable position:sticky in release builds (already done in B2G)

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla32
Tracking Status
relnote-firefox --- 32+

People

(Reporter: coyotebush, Assigned: kip)

References

Details

(Keywords: dev-doc-complete, feature, perf)

Attachments

(1 file)

Bug 902992 enables position:sticky only on Nightly and Aurora. Among other things, we should wait for a more stable specification before enabling it on Beta and Release.
Depends on: 915302, 916302, 915474, 915476
Depends on: 930419
Depends on: 931450
Depends on: 931460
Blocks: 945472
Blocks: 945481
No longer blocks: 945481
No longer blocks: 945472
No longer blocks: 942460
Depends on: 926728
Depends on: 946235
Can we prioritize that for 1.4 ? 

The code of sms/contacts/call log is using their own fixed header solution implemented in JS and will let us remove it as well as saving some extra repaints.
The feeling of fixed headers will be also much better since the current code relies on "scroll" events and the fixed headers are lagging behind the user gesture with APZC enabled.
blocking-b2g: --- → 1.4?
David, can we get this for 1.4?
Flags: needinfo?(dbaron)
Keywords: perf
Assignee: nobody → dbaron
Milan

Do we need this for 1.4? Or is this something that can be moved to 1.5
Flags: needinfo?(milan)
I'm basing 1.4+ on Comment 1, so I'll leave it to Vivien to answer that. I personally have a feeling that this would be identified as a blocker by our partners, but only in a few weeks, at which point it would be much more expensive to fix.
Flags: needinfo?(milan)
Actually, I think this is enabled in B2G already (bug 945777), and most of our apps are now using position:sticky (eg bug 945481 for Messages).

Not sure why this bug is a blocker then.
Got it.  I'll update the summary so that it's clear this is for non-B2G platforms.
blocking-b2g: 1.4? → ---
Flags: needinfo?(dbaron)
Summary: enable position:sticky in release builds → enable position:sticky in release builds (already done in B2G)
Depends on: 979602
Any ETA? Would be great if that could be activated soon. Fiddling around with sicky js-libraries that all are a bit buggy (for our use-case, for others they seem to work just fine), where-as position:sticky on the nightly works perfectly.
Depends on: 983523
No longer depends on: 915302
No longer depends on: 979602
This patch enables the layout.css.sticky.enabled preference by default in release builds.
Attachment #8418434 - Flags: review?(dbaron)
Did you send an intent to ship message to dev-platform per https://wiki.mozilla.org/WebAPI/ExposureGuidelines ?
Assignee: dbaron → kgilbert
Flags: needinfo?(kgilbert)
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #9)
> Did you send an intent to ship message to dev-platform per
> https://wiki.mozilla.org/WebAPI/ExposureGuidelines ?

I have sent the intent to ship message to dev-platform and am awaiting feedback.
Flags: needinfo?(kgilbert)
FYI, I think we had to disable position:sticky in a number of gaia apps for performance reasons.  For example, see bug 977680 and bug 978067.  I guess the issue is that it creates additional layerization costs.

I don't think this should hold up exposing the API, but just wanted to share that since comment 5 mentioned b2g was using it.
Attachment #8418434 - Flags: review?(dbaron) → review+
Attachment #8418434 - Attachment description: Bug 916315 Patch To Enable Sticky Preference By Default → Bug 916315 Patch To Enable Sticky Preference By Default, r=dbaron
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/15cb2598a361
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Thead and table type of element is still not supported Sticky, Chrome Canary has supported.
(In reply to David Baron [:dbaron] (Away/Busy May 10-22) (UTC+9) from comment #15)
> That's bug 975644.

Thanks! Current position: sticky does not seem to realize iOS 7 contacts that effect.
relnote-firefox: --- → ?
Verified on Win 7 x64, Ubuntu 12.10 x86, Mac OS X 10.9.4 with Firefox 32 Beta 1 (BuildID: 20140722195627): "layout.css.sticky.enabled" pref is "true" by default, and position sticky seems to work fine (http://html5-demos.appspot.com/static/css/sticky.html).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.