Closed Bug 945513 Opened 6 years ago Closed 6 years ago

Opus-in-WebM test files

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: rillian, Assigned: j)

References

Details

Attachments

(3 files, 3 obsolete files)

We've enabled playback support for the Opus codec in the WebM container. We should add some files to the testsuite to verify.
Attached video detodos.webm (obsolete) —
opus remuxed into webm from detodos.opus
Assignee: giles → j
Attachment #8347176 - Flags: review?(giles)
Comment on attachment 8347176 [details] [diff] [review]
0001-Bug-945513-Opus-in-WebM-tests.patch

Review of attachment 8347176 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine. I'd also like to see nobeeps, the multichannel and invalid channel mapping tests remuxed as webm.

Please document the tool you used to mux the webm files in the commit message.

::: content/media/test/can_play_type_webm.js
@@ +12,5 @@
>    check("video/webm; codecs=vorbis", "probably");
>    check("video/webm; codecs=vorbis,vp8", "probably");
>    check("video/webm; codecs=vorbis,vp8.0", "probably");
> +  check("audio/webm; codecs=opus", "probably");
> +  check("video/webm; codecs=opus", "probably");

Should also check for 'video/web; codecs=vp8,opus' etc. If you want to parameterize it though, best to make that a separate bug.
Attachment #8347176 - Flags: review?(giles) → review+
include webm file in patch.
Attachment #8347173 - Attachment is obsolete: true
Attachment #8347176 - Attachment is obsolete: true
Attachment #8347937 - Flags: review?(giles)
Blocks: 950793
(In reply to Ralph Giles (:rillian) from comment #3)
> Comment on attachment 8347176 [details] [diff] [review]
> 0001-Bug-945513-Opus-in-WebM-tests.patch
> 
> Review of attachment 8347176 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is fine. I'd also like to see nobeeps, the multichannel and invalid
> channel mapping tests remuxed as webm.

Will have to look into those, which one is nobeeps?
 
> Please document the tool you used to mux the webm files in the commit
> message.

detodos.webm contains the metadata tags about this:

| + Muxing application: Lavf55.22.100
| + Writing application: Lavf55.22.100

but can also add to commit message.

> 
> ::: content/media/test/can_play_type_webm.js
> @@ +12,5 @@
> >    check("video/webm; codecs=vorbis", "probably");
> >    check("video/webm; codecs=vorbis,vp8", "probably");
> >    check("video/webm; codecs=vorbis,vp8.0", "probably");
> > +  check("audio/webm; codecs=opus", "probably");
> > +  check("video/webm; codecs=opus", "probably");
> 
> Should also check for 'video/web; codecs=vp8,opus' etc. If you want to
> parameterize it though, best to make that a separate bug.

ok created Bug 950793 to turn that list into a loop once vp9 and opus tests are in.
Add ffmpeg version used to remux file to commit message.
Attachment #8347937 - Attachment is obsolete: true
Attachment #8347937 - Flags: review?(giles)
Attachment #8348198 - Flags: review?(giles)
Comment on attachment 8348198 [details] [diff] [review]
0001-Bug-945513-Opus-in-WebM-tests.patch

No beeps is https://people.xiph.org/~greg/opus_testvectors/correctness_trimming_nobeeps.opus

I believe you already did a remux for our local testing.
Attachment #8348198 - Flags: review?(giles) → review+
Depends on: 951770
created with:
ffmpeg -i correctness_trimming_nobeeps.opus -strict -2 -acodec copy correctness_trimming_nobeeps.webm

source from http://people.xiph.org/~greg/opus_testvectors/correctness_trimming_nobeeps.opus
https://hg.mozilla.org/mozilla-central/rev/3aab84544332
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.