945513 - Opus-in-WebM test files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

We've enabled playback support for the Opus codec in the WebM container. We should add some files to the testsuite to verify.

Comment 1

[Jan Gerber]

Attachment: detodos.webm

opus remuxed into webm from detodos.opus

Comment 2

[Jan Gerber]

Attachment: 0001-Bug-945513-Opus-in-WebM-tests.patch

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8347176 [details] [diff] [review]
0001-Bug-945513-Opus-in-WebM-tests.patch

Review of attachment 8347176 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine. I'd also like to see nobeeps, the multichannel and invalid channel mapping tests remuxed as webm.

Please document the tool you used to mux the webm files in the commit message.

::: content/media/test/can_play_type_webm.js
@@ +12,5 @@
>    check("video/webm; codecs=vorbis", "probably");
>    check("video/webm; codecs=vorbis,vp8", "probably");
>    check("video/webm; codecs=vorbis,vp8.0", "probably");
> +  check("audio/webm; codecs=opus", "probably");
> +  check("video/webm; codecs=opus", "probably");

Should also check for 'video/web; codecs=vp8,opus' etc. If you want to parameterize it though, best to make that a separate bug.

Comment 4

[Jan Gerber]

Attachment: 0001-Bug-945513-Opus-in-WebM-tests.patch

include webm file in patch.

Comment 5

[Jan Gerber]

(In reply to Ralph Giles (:rillian) from comment #3)
> Comment on attachment 8347176 [details] [diff] [review]
> 0001-Bug-945513-Opus-in-WebM-tests.patch
> 
> Review of attachment 8347176 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is fine. I'd also like to see nobeeps, the multichannel and invalid
> channel mapping tests remuxed as webm.

Will have to look into those, which one is nobeeps?
 
> Please document the tool you used to mux the webm files in the commit
> message.

detodos.webm contains the metadata tags about this:

| + Muxing application: Lavf55.22.100
| + Writing application: Lavf55.22.100

but can also add to commit message.

> 
> ::: content/media/test/can_play_type_webm.js
> @@ +12,5 @@
> >    check("video/webm; codecs=vorbis", "probably");
> >    check("video/webm; codecs=vorbis,vp8", "probably");
> >    check("video/webm; codecs=vorbis,vp8.0", "probably");
> > +  check("audio/webm; codecs=opus", "probably");
> > +  check("video/webm; codecs=opus", "probably");
> 
> Should also check for 'video/web; codecs=vp8,opus' etc. If you want to
> parameterize it though, best to make that a separate bug.

ok created Bug 950793 to turn that list into a loop once vp9 and opus tests are in.

Comment 6

[Jan Gerber]

Attachment: 0001-Bug-945513-Opus-in-WebM-tests.patch

Add ffmpeg version used to remux file to commit message.

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8348198 [details] [diff] [review]
0001-Bug-945513-Opus-in-WebM-tests.patch

No beeps is https://people.xiph.org/~greg/opus_testvectors/correctness_trimming_nobeeps.opus

I believe you already did a remux for our local testing.

Comment 8

[Jan Gerber]

Attachment: correctness_trimming_nobeeps.webm

created with:
ffmpeg -i correctness_trimming_nobeeps.opus -strict -2 -acodec copy correctness_trimming_nobeeps.webm

source from http://people.xiph.org/~greg/opus_testvectors/correctness_trimming_nobeeps.opus

Comment 9

[Jan Gerber]

Attachment: test-6-5.1.webm

5.1 test remuxed from http://people.xiph.org/~greg/opus_testvectors/opus_multichannel_examples/test-6-5.1.opus

Comment 10

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3aab84544332

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3aab84544332