945562 - [Camera] Camcorder fails to create video files with permission error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Inder]

Video recording is not working on our reference hardware with this error message:
"Couldn't create file '/storage/sdcard1/DCIM/100MZLLA/VID_0001.3gp': (13) Permission denied"

Adding AID_SDCARD_R and AID_MEDIA_RW to the camera group privileges fixes the issue:
https://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/process_util_linux.cc#306

We need to make this change to unblock camcorder functionality on v1.3

Comment 1

[Inder]

Another possible fix is to land the fix in bug 910498, where we delegate the fd creation to b2g process.

Comment 2

[Madana Manjunatha]

:inder do we have a fix for media detection after the video capture and from video player for qcom devices?

Comment 3

[Inder]

(In reply to Madana Manjunatha from comment #2)
> :inder do we have a fix for media detection after the video capture and from
> video player for qcom devices?

Yes, that was fixed by bug 939211.

Comment 4

[Madana Manjunatha]

:ikumar i am working on qcom device, After the video capture, the recorded video file should be added to the filmstrip. For me, it is not getting added to the film strip.

Can you please confirm?

Comment 5

[Inder]

(In reply to Madana Manjunatha from comment #4)
> :ikumar i am working on qcom device, After the video capture, the recorded
> video file should be added to the filmstrip. For me, it is not getting added
> to the film strip.
> 
> Can you please confirm?
Recorded videos show up fine in the video app. Please pick the latest code from CAF.

Comment 6

[Inder]

Attachment: Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Comment 7

[Dave Hylands [:dhylands]]

Comment on attachment 8342749 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Review of attachment 8342749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me...

Comment 8

[Inder]

Attachment: Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Fix patch format.
Carry forward :dylands review+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4c2bc5ae8f95

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/b2g-inbound/rev/954aa0768ac6

https://tbpl.mozilla.org/php/getParsedLog.php?id=31467300&tree=B2g-Inbound

Comment 11

[Michael Vines [:m1] [:evilmachines]]

ICS!  

ikumar -- you have try access right?

Comment 12

[Inder]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #11)
> ICS!  
> 
> ikumar -- you have try access right?

Yes, I do. Sorry, next time will use that first.

Will need conditional compilation here. Will upload a new patch.

Comment 13

[Inder]

Attachment: Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups in jb

Added conditional compilation.
Carry forward Dave's review+ because no new code besides the conditional compilation.

Comment 14

[Inder]

verified on try: https://tbpl.mozilla.org/?tree=Try&rev=d59b7297490e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0ae6abb440f5

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ae6abb440f5

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68d9a97603e8

Comment 18

[KTucker [:KTucker][Inactive 3/4/2016]]

The test case has been added here in Moztrap: https://moztrap.mozilla.org/manage/case/13753/