[Camera] Camcorder fails to create video files with permission error

RESOLVED FIXED in Firefox 28, Firefox OS v1.3

Status

Firefox OS
Gaia::Camera
--
critical
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Inder, Assigned: Inder)

Tracking

(Blocks: 1 bug)

unspecified
1.3 C1/1.4 S1(20dec)
ARM
Gonk (Firefox OS)
Bug Flags:
in-testsuite +
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Details

(Whiteboard: [fxos:media])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
Video recording is not working on our reference hardware with this error message:
"Couldn't create file '/storage/sdcard1/DCIM/100MZLLA/VID_0001.3gp': (13) Permission denied"

Adding AID_SDCARD_R and AID_MEDIA_RW to the camera group privileges fixes the issue:
https://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/process_util_linux.cc#306

We need to make this change to unblock camcorder functionality on v1.3
(Assignee)

Comment 1

4 years ago
Another possible fix is to land the fix in bug 910498, where we delegate the fd creation to b2g process.

Comment 2

4 years ago
:inder do we have a fix for media detection after the video capture and from video player for qcom devices?

Updated

4 years ago
Flags: needinfo?(ikumar)
(Assignee)

Comment 3

4 years ago
(In reply to Madana Manjunatha from comment #2)
> :inder do we have a fix for media detection after the video capture and from
> video player for qcom devices?

Yes, that was fixed by bug 939211.
Flags: needinfo?(ikumar)
Assignee: nobody → ikumar
blocking-b2g: 1.3? → 1.3+

Comment 4

4 years ago
:ikumar i am working on qcom device, After the video capture, the recorded video file should be added to the filmstrip. For me, it is not getting added to the film strip.

Can you please confirm?
Flags: needinfo?(ikumar)
(Assignee)

Comment 5

4 years ago
(In reply to Madana Manjunatha from comment #4)
> :ikumar i am working on qcom device, After the video capture, the recorded
> video file should be added to the filmstrip. For me, it is not getting added
> to the film strip.
> 
> Can you please confirm?
Recorded videos show up fine in the video app. Please pick the latest code from CAF.
Flags: needinfo?(ikumar)
(Assignee)

Comment 6

4 years ago
Created attachment 8342749 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups
Attachment #8342749 - Flags: review?(dhylands)
Comment on attachment 8342749 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Review of attachment 8342749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me...
Attachment #8342749 - Flags: review?(dhylands) → review+
(Assignee)

Comment 8

4 years ago
Created attachment 8342764 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Fix patch format.
Carry forward :dylands review+
Attachment #8342749 - Attachment is obsolete: true
Attachment #8342764 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/4c2bc5ae8f95
Keywords: checkin-needed
Backed out for bustage.
https://hg.mozilla.org/integration/b2g-inbound/rev/954aa0768ac6

https://tbpl.mozilla.org/php/getParsedLog.php?id=31467300&tree=B2g-Inbound
ICS!  

ikumar -- you have try access right?
(Assignee)

Comment 12

4 years ago
(In reply to Michael Vines [:m1] [:evilmachines] from comment #11)
> ICS!  
> 
> ikumar -- you have try access right?

Yes, I do. Sorry, next time will use that first.

Will need conditional compilation here. Will upload a new patch.
Blocks: 930299
(Assignee)

Comment 13

4 years ago
Created attachment 8344520 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups in jb

Added conditional compilation.
Carry forward Dave's review+ because no new code besides the conditional compilation.
Attachment #8342764 - Attachment is obsolete: true
Attachment #8344520 - Flags: review+
Blocks: 942267
No longer blocks: 930299
(Assignee)

Comment 14

4 years ago
verified on try: https://tbpl.mozilla.org/?tree=Try&rev=d59b7297490e
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/0ae6abb440f5
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0ae6abb440f5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-b2g-v1.3: --- → affected
https://hg.mozilla.org/releases/mozilla-aurora/rev/68d9a97603e8
status-b2g-v1.3: affected → fixed
status-firefox27: --- → wontfix
status-firefox28: --- → fixed
status-firefox29: --- → fixed
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)

Updated

4 years ago
Whiteboard: [fxos:media]

Updated

4 years ago
Flags: in-testsuite+
status-b2g-v1.3T: --- → fixed
status-b2g-v1.4: --- → fixed

Updated

4 years ago
Flags: in-moztrap-
The test case has been added here in Moztrap: https://moztrap.mozilla.org/manage/case/13753/
Flags: in-moztrap- → in-moztrap+
You need to log in before you can comment on or make changes to this bug.