Closed Bug 945562 Opened 6 years ago Closed 6 years ago

[Camera] Camcorder fails to create video files with permission error

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, critical)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)
blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: ikumar, Assigned: ikumar)

Details

(Whiteboard: [fxos:media])

Attachments

(1 file, 2 obsolete files)

Video recording is not working on our reference hardware with this error message:
"Couldn't create file '/storage/sdcard1/DCIM/100MZLLA/VID_0001.3gp': (13) Permission denied"

Adding AID_SDCARD_R and AID_MEDIA_RW to the camera group privileges fixes the issue:
https://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/process_util_linux.cc#306

We need to make this change to unblock camcorder functionality on v1.3
Another possible fix is to land the fix in bug 910498, where we delegate the fd creation to b2g process.
:inder do we have a fix for media detection after the video capture and from video player for qcom devices?
Flags: needinfo?(ikumar)
(In reply to Madana Manjunatha from comment #2)
> :inder do we have a fix for media detection after the video capture and from
> video player for qcom devices?

Yes, that was fixed by bug 939211.
Flags: needinfo?(ikumar)
Assignee: nobody → ikumar
blocking-b2g: 1.3? → 1.3+
:ikumar i am working on qcom device, After the video capture, the recorded video file should be added to the filmstrip. For me, it is not getting added to the film strip.

Can you please confirm?
Flags: needinfo?(ikumar)
(In reply to Madana Manjunatha from comment #4)
> :ikumar i am working on qcom device, After the video capture, the recorded
> video file should be added to the filmstrip. For me, it is not getting added
> to the film strip.
> 
> Can you please confirm?
Recorded videos show up fine in the video app. Please pick the latest code from CAF.
Flags: needinfo?(ikumar)
Attachment #8342749 - Flags: review?(dhylands)
Comment on attachment 8342749 [details] [diff] [review]
Camera also needs AID_SDCARD_R and AID_MEDIA_RW groups

Review of attachment 8342749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me...
Attachment #8342749 - Flags: review?(dhylands) → review+
Fix patch format.
Carry forward :dylands review+
Attachment #8342749 - Attachment is obsolete: true
Attachment #8342764 - Flags: review+
Keywords: checkin-needed
ICS!  

ikumar -- you have try access right?
(In reply to Michael Vines [:m1] [:evilmachines] from comment #11)
> ICS!  
> 
> ikumar -- you have try access right?

Yes, I do. Sorry, next time will use that first.

Will need conditional compilation here. Will upload a new patch.
Added conditional compilation.
Carry forward Dave's review+ because no new code besides the conditional compilation.
Attachment #8342764 - Attachment is obsolete: true
Attachment #8344520 - Flags: review+
verified on try: https://tbpl.mozilla.org/?tree=Try&rev=d59b7297490e
Keywords: checkin-needed
Whiteboard: [fxos:media]
Flags: in-testsuite+
Flags: in-moztrap-
The test case has been added here in Moztrap: https://moztrap.mozilla.org/manage/case/13753/
Flags: in-moztrap- → in-moztrap+
You need to log in before you can comment on or make changes to this bug.