945587 - nsXULTemplateResultStorage.cpp:12:22: error: redefinition of 'kRDFServiceCID' when building with 12 unified sources instead of 16

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mike Hommey [:glandium]]

Open python/mozbuild/mozbuild/backend/recursivemake.py, search for files_per_unification, replace its value (16) with 12.

This is the (one of the multiple) error(s) you can get then:

content/xul/templates/src/nsXULTemplateResultStorage.cpp:12:22: error: redefinition of 'kRDFServiceCID'
static NS_DEFINE_CID(kRDFServiceCID, NS_RDFSERVICE_CID);
                     ^
../../../../dist/include/nsID.h:86:15: note: expanded from macro 'NS_DEFINE_CID'
  const nsCID _name = _cidspec
              ^
content/xul/templates/src/nsXULContentUtils.cpp:64:22: note: previous definition is here
static NS_DEFINE_CID(kRDFServiceCID,        NS_RDFSERVICE_CID);

Comment 1

[Mike Hommey [:glandium]]

This should probably be made about all the possible similar cases in the tree, that are just future bugs in hiding.

The pattern being static NS_DEFINE_CID at global scope for the same symbol, in the same directory.

Comment 2

[(no longer active)]

Attachment: Stop using the kRDFServiceCID name in content/xul

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8341677 [details] [diff] [review]
Stop using the kRDFServiceCID name in content/xul

r=me

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/582c563a8e1a

Comment 5

[(no longer active)]

Backed out because apparently f({0, 1, ...}) is not C++?

https://hg.mozilla.org/integration/mozilla-inbound/rev/38ddf36afa9d

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65b997a2db9a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/65b997a2db9a