945727 - [Cards View] It's difficult to tap the cross in the cards view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* launch an app
* longpress the home button
* try to close the app pressing the cross button

Expected:
* it's easy to tap on it

Actual:
* it's difficult to tap on it.

Checked with Vivien, the cross is a <div>, which probably causes the issue because of the event fluffing. He's ok with simply adding a "role=button" to this div, because this code will hopefully be rewritten soon.

Comment 1

[Jason Smith [:jsmith]]

I believe event fluffing is turned off in 1.2 or earlier, so this sounds like a fallout from that. Can someone double check this doesn't reproduce on 1.2?

Comment 2

[Matthew Vaughan]

Another tester and I tested on two Buri devices, one with the 11/26 1.2 build and one with the 12/03 1.2 build. I attempted to tap the 'X' buttons lightly while the other tester tapped the buttons a little more quickly and with a little more pressure. The results are tapping the 'X' buttons lightly makes it easier, while tapping the buttons quickly with more pressure makes it a fair bit more difficult. This appears to be a user specific issue for the most part.

- 12/03 1.2 BUILD -
Environmental Variables:
Device: Buri 1.2 COM RIL
BuildID: 20131203004002
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Gecko: 244e98241b2c
Version: 26.0
Firmware Version: v1.2_20131115
RIL Version: 01.02.00.019.102

Comment 3

[Jason Smith [:jsmith]]

(In reply to Matthew Vaughan from comment #2)
> Another tester and I tested on two Buri devices, one with the 11/26 1.2
> build and one with the 12/03 1.2 build. I attempted to tap the 'X' buttons
> lightly while the other tester tapped the buttons a little more quickly and
> with a little more pressure. The results are tapping the 'X' buttons lightly
> makes it easier, while tapping the buttons quickly with more pressure makes
> it a fair bit more difficult. This appears to be a user specific issue for
> the most part.
> 
> - 12/03 1.2 BUILD -
> Environmental Variables:
> Device: Buri 1.2 COM RIL
> BuildID: 20131203004002
> Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
> Gecko: 244e98241b2c
> Version: 26.0
> Firmware Version: v1.2_20131115
> RIL Version: 01.02.00.019.102

How does this compare to 1.3?

Comment 4

[Julien Wajsberg [:julienw]]

I don't know if event fluffing is turned on in 1.2 these days. Vivien told me it will eventually be turned off but I don't know if that's been done yet.

For proper comparison this should be compared to 1.1.

Comment 5

[Matthew Vaughan]

Another tester and I checked on the latest available Buri 1.1 and 1.3 builds along with the Leo 12/03 1.1 build. It really seems that selecting the 'X' buttons in these builds are pretty much comparable to the 1.2 builds mentioned in comment 2. The only thing we noticed is that the 'X' buttons in the 1.1 build (both Buri & Leo) appear to be a little easier to select; a little more forgiving if the user's finger is not precisely on the button.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> I don't know if event fluffing is turned on in 1.2 these days. Vivien told
> me it will eventually be turned off but I don't know if that's been done yet.
> 
> For proper comparison this should be compared to 1.1.

The bug to disable it is bug 944347

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug945727.patch

Julien, here is a small patch based on the theory we discussed IRL. I know you like to try the patches you reviewed, so I didn't try by myself ;)

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8342652 [details] [diff] [review]
bug945727.patch

r=me

not enough but this is a first step.
Will also help a11y.

Comment 9

[Julien Wajsberg [:julienw]]

master: 3b019153ecb9ab3a3bca2a789ba88a1207639585