Closed Bug 945861 Opened 7 years ago Closed 7 years ago

Cleanup the folderPane.css

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 28.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

This bug is to cleanup the folderPane.css files. The main focus is to move on Linux and Windows the separate .tabmail-tab[type="folder"][IsServer="true"] rules together with the treechildren::-moz-tree-image(folderNameCol, isServer-true) rules like they are on OS X. They are using the same rules and it makes no sense tho leave them separate as this makes doing errors easier and have them out of synch (see on Linux the wrong definition: http://mxr.mozilla.org/comm-central/source/mail/themes/linux/mail/folderPane.css#151 and on Windows the not existing area: http://mxr.mozilla.org/comm-central/source/mail/themes/windows/mail/folderPane.css#173).

This bug is also to move the isServer-true to be always on the second attribute position for easier reading and rule comparison (also to be in synch with the .tabmail-tab selector.
Attached patch patch β€” β€” Splinter Review
Patch is doing what is in comment 0 described.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8341878 - Flags: review?(josiah)
Comment on attachment 8341878 [details] [diff] [review]
patch

Review of attachment 8341878 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this took so long. Looks great though! Thanks Richard.
Attachment #8341878 - Flags: review?(josiah) → review+
Keywords: checkin-needed
Looks like Josiah pushed this and forgot to mark the bug. Please don't forget as it wastes other people's time when you do :)
https://hg.mozilla.org/comm-central/rev/69f32f659a32
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(josiah)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #3)
> Looks like Josiah pushed this and forgot to mark the bug. Please don't
> forget as it wastes other people's time when you do :)
> https://hg.mozilla.org/comm-central/rev/69f32f659a32

Ah rats. So sorry about that. :(
Thanks for letting me know, won't let it happen again.
Flags: needinfo?(josiah)
Not a problem. As a quick heads-up, if you use mcMerge to mark the bugs, it'll take care of all that for you. When you hover over a push on TBPL, you can see it on the right side.
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> Not a problem. As a quick heads-up, if you use mcMerge to mark the bugs,
> it'll take care of all that for you. When you hover over a push on TBPL, you
> can see it on the right side.

Sweet. Didn't know about that. Thanks!
You need to log in before you can comment on or make changes to this bug.