Re-enable DirectShow for MP3 playback on Vista and later

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

({verifyme})

unspecified
mozilla28
x86_64
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 930372 we disabled using DirectShow for MP3 playback in <audio> on Vista and later because it was reporting the incorrect duration, whereas our WMF backend was not. Now that bug 918135 has landed that is no longer an issue, so we should re-enable it so that we don't suffer from bug 882537 for MP3 playback on Windows.
Depends on: 918135
Posted patch PatchSplinter Review
Re-enable using DirectShow for MP3 playback in <audio> on all Windows versions.
Attachment #8341965 - Flags: review?(ajones)
Attachment #8341965 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/ccb5e249ab11
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Unfortunately Firefox 26 released without this, so jsrage.com and other games/demos that are now attempting to load MP3s instead of OGGs (such as http://xhva.net/test/canvas/shooter/) experience arbitrary audio loss problems that weren't present before (Bug 882537, Bug 936796).

I'm not sure of the impact on other game/audio libraries that previously loaded non-MP3 sources for Firefox.
Blocks: 960106
Keywords: verifyme
Setting myself as QA Contact for testing this. Ioana, you can skip this bug for now in your Beta testing. I need to follow up with the games team about what demos might be advisable to test here.
QA Contact: anthony.s.hughes
Depends on: 978647
Depends on: 986925
Depends on: 986947
Depends on: 1070485
See Also: → 1222725
QA Whiteboard: [QAnalyst-Triage?] [QAExclude]
Flags: needinfo?(jmercado)
This is something that QAnalysts cannot verify.
QA Whiteboard: [QAnalyst-Triage?] [QAExclude] → [QAExclude]
Flags: needinfo?(jmercado)
You need to log in before you can comment on or make changes to this bug.