945947 - Re-enable DirectShow for MP3 playback on Vista and later

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (GMT+13)]]

In bug 930372 we disabled using DirectShow for MP3 playback in <audio> on Vista and later because it was reporting the incorrect duration, whereas our WMF backend was not. Now that bug 918135 has landed that is no longer an issue, so we should re-enable it so that we don't suffer from bug 882537 for MP3 playback on Windows.

Comment 1

[Chris Pearce [:cpearce (GMT+13)]]

Attachment: Patch

Re-enable using DirectShow for MP3 playback in <audio> on all Windows versions.

Comment 2

[Chris Pearce [:cpearce (GMT+13)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb5e249ab11

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ccb5e249ab11

Comment 4

[Andrew Stibbard]

Unfortunately Firefox 26 released without this, so jsrage.com and other games/demos that are now attempting to load MP3s instead of OGGs (such as http://xhva.net/test/canvas/shooter/) experience arbitrary audio loss problems that weren't present before (Bug 882537, Bug 936796).

I'm not sure of the impact on other game/audio libraries that previously loaded non-MP3 sources for Firefox.

Comment 5

[u279076]

Setting myself as QA Contact for testing this. Ioana, you can skip this bug for now in your Beta testing. I need to follow up with the games team about what demos might be advisable to test here.

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This is something that QAnalysts cannot verify.