946047 - [B2G][Settings][NFC] Fix HasNfcSupport in MozNfc.webidl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Garner Lee]

Attachment: 0001-Fix-HasNfcSupport-in-MozNfc.webidl.patch r=khuey

In Bug 939056, there's a small webidl fix to Settings UI, NFC that also completely hides the NFC setting from the UI.

This bug just fixes that MozNfc.webidl, by adding HasNfcSupport to the definition.

The only way to get it to show on Nexus 4 (or other targeted phones), is to add the "nfc-read" permission to the settings' manifest.webapp file.

Comment 1

[Garner Lee]

Ken, since we don't have an approved solution in place in 939056, I made this bug. If we land it all at once soon, please close this bug.

Comment 2

[Garner Lee]

Attachment: Settings UI permission fix if HasNfcSupport is added to MozNfc.webidl

Comment 3

[Evelyn Hung]

Comment on attachment 8342542 [details] [review]
Settings UI permission fix if HasNfcSupport is added to MozNfc.webidl

looks good to me on explicitly requesting NFC permission in manifest file.
Please rebase your patch for merge. Thanks!

Comment 4

[Garner Lee]

Try: https://tbpl.mozilla.org/?tree=Try&rev=315a779a6ef7

Comment 5

[Garner Lee]

Attachment: 0001-Bug-946047-Remove-MozNfc-from-global-scope-in-test_i.patch

Fix mochitest-8 test_interfaces.html MozNfc global scope declaration. HasNfcSupport determines whether MozNfc appears.

Comment 6

[Garner Lee]

See mochitest-8 testcase fix in this try run:
https://tbpl.mozilla.org/?tree=Try&rev=ac83161bfdd4

Comment 7

[Garner Lee]

Gecko side webidl: check-in needed.

Gaia: Travis-CI tests: keyboard test bugged, but Settings UI change is unlikely to be related: https://travis-ci.org/mozilla-b2g/gaia/builds/15023166

Comment 8

[Garner Lee]

Travis-ci, new results (running): https://travis-ci.org/mozilla-b2g/gaia/builds/15070342

Comment 9

[Evelyn Hung]

I can't merge it since Gaia tree closed again. keep the ni flag to remind me later.

Comment 10

[Evelyn Hung]

travis failed even I re-tried it twice. Someone told me rebase PR will help. Can you do it?

Comment 11

[Garner Lee]

I just pushed to github from the lastest Gaia: https://travis-ci.org/mozilla-b2g/gaia/builds/15209799, base: 6865061768d4c78f391dee4ff04d825f8d829843

Comment 12

[Garner Lee]

Rebased and pushed yet again, and it actually passed!
https://travis-ci.org/mozilla-b2g/gaia/builds/15251993

Comment 13

[Evelyn Hung]

(In reply to Garner Lee from comment #12)
> Rebased and pushed yet again, and it actually passed!
> https://travis-ci.org/mozilla-b2g/gaia/builds/15251993

Gaia: merged into master https://github.com/mozilla-b2g/gaia/commit/3d0b2fbda4a3495756ae700f011b59c4e22dec0d

Comment 14

[Garner Lee]

Hi Ken, considering the other bug just opened, this is more of a bug fix than a change to the DOM. sr still needed?

Comment 15

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/integration/b2g-inbound/rev/d4725eeb419d

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4725eeb419d

Comment 17

[Ken Chang[:kenkai]]

No more information is need.

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

Hi, Joe, Tarako depends on bug 939056 which is blocked by this bug. So I think this buy also should block 1.3+ as bug 939056.

Comment 19

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aa2f87cedc09

Comment 20

[Joe Cheng [:jcheng] (please needinfo)]

status-b2g-v1.3T: fixed in tarako branch, remove [tarako] in whiteboard