Closed Bug 946069 Opened 11 years ago Closed 9 years ago

10.9 is very angry about use of an invalid context in test_canvas.html

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: philor, Assigned: milan)

References

Details

Attachments

(1 file, 1 obsolete file)

Assert and annotate crash report if we run into invalid contexts. Also check for empty path before asking for a current point. r=mstange
18.00 KB, patch
mstange
: review+
Details | Diff | Splinter Review 
Not going to be much fun to fix if it doesn't repro locally, because we have 10.9 test enabled only on Cedar, and we have exactly one test slave to run them.

https://tbpl.mozilla.org/php/getParsedLog.php?id=31397279&tree=Cedar
https://tbpl.mozilla.org/php/getParsedLog.php?id=31408540&tree=Cedar

16:05:46     INFO -  68081 INFO TEST-PASS | /tests/content/canvas/test/test_canvas.html | pixel 50,25 of c22 is 218,255,36,223; expected 218,255,36,223 +/- 5
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextTranslateCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextScaleCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextSetShouldAntialias: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextConcatCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextSetFillColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextFillRects: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  68082 INFO TEST-PASS | /tests/content/canvas/test/test_canvas.html | pixel 25,25 of c24 is 0,255,0,255; expected 0,255,0,255 +/- 0
16:05:46     INFO -  68083 INFO TEST-PASS | /tests/content/canvas/test/test_canvas.html | pixel 75,25 of c24 is 0,255,0,255; expected 0,255,0,255 +/- 0
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextTranslateCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextScaleCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextSetShouldAntialias: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextConcatCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextSetFillColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
16:05:46     INFO -  Dec  3 16:05:46 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1632] <Error>: CGContextFillRects: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

etc. etc.
Blocks: 947089
This remains a consistent problem in 10.9 runs on Cedar, on both Opt and Debug:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46438932&tree=Cedar&full=1#error0
https://tbpl.mozilla.org/php/getParsedLog.php?id=46432607&tree=Cedar&full=1#error0

22:53:38     INFO -  1216 INFO TEST-START | /tests/dom/canvas/test/test_canvas.html
22:53:39     INFO -  1217 INFO Aug 20 22:53:39 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1665] <Error>: CGPoint CGPathGetCurrentPoint(CGPathRef): no current point.
22:53:39     INFO -  1218 INFO Aug 20 22:53:39 t-mavericks-r5-001.test.releng.scl3.mozilla.com firefox[1665] <Error>: clip: empty path.
22:53:39     INFO -  1219 INFO dumping last 100 message(s)
22:53:39     INFO -  1220 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1221 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 2 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1222 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 3 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1223 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 4 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1224 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 5 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1225 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 6 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1226 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 7 in test image data after clearing pixels for slow test #2
22:53:39     INFO -  1227 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1228 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 0 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1229 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 1 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1230 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 2 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1231 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 3 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1232 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 4 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1233 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 5 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1234 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 6 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1235 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 7 in test image data after putting our imagedata for slow test #2
22:53:39     INFO -  1236 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length mismatch for slow test #3
22:53:39     INFO -  1237 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length not a multiple of 4 for slow test #3
22:53:39     INFO -  1238 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data width for slow test #3
22:53:39     INFO -  1239 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data height for slow test #3
22:53:39     INFO -  1240 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in created image data for slow test #3
22:53:39     INFO -  1241 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1242 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 0 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1243 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 1 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1244 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 2 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1245 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 3 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1246 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 4 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1247 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 5 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1248 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 6 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1249 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 7 in test image data after clearing pixels for slow test #3
22:53:39     INFO -  1250 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1251 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 0 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1252 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 1 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1253 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 2 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1254 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 3 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1255 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 4 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1256 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 5 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1257 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 6 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1258 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 7 in test image data after putting our imagedata for slow test #3
22:53:39     INFO -  1259 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length mismatch for slow test #4
22:53:39     INFO -  1260 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length not a multiple of 4 for slow test #4
22:53:39     INFO -  1261 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data width for slow test #4
22:53:39     INFO -  1262 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data height for slow test #4
22:53:39     INFO -  1263 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in created image data for slow test #4
22:53:39     INFO -  1264 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1265 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 0 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1266 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 1 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1267 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 2 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1268 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 3 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1269 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 4 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1270 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 5 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1271 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 6 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1272 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 7 in test image data after clearing pixels for slow test #4
22:53:39     INFO -  1273 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1274 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 0 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1275 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 1 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1276 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 2 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1277 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 3 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1278 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 4 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1279 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 5 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1280 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 6 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1281 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 7 in test image data after putting our imagedata for slow test #4
22:53:39     INFO -  1282 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length mismatch for slow test #5
22:53:39     INFO -  1283 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Length not a multiple of 4 for slow test #5
22:53:39     INFO -  1284 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data width for slow test #5
22:53:39     INFO -  1285 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect created data height for slow test #5
22:53:39     INFO -  1286 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in created image data for slow test #5
22:53:39     INFO -  1287 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1288 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 0 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1289 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 1 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1290 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 2 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1291 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 3 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1292 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 4 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1293 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 5 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1294 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 6 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1295 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Nonzero value at position 7 in test image data after clearing pixels for slow test #5
22:53:39     INFO -  1296 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect length in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1297 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 0 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1298 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 1 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1299 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 2 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1300 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 3 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1301 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 4 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1302 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 5 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1303 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 6 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1304 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | Incorrect value at position 7 in test image data after putting our imagedata for slow test #5
22:53:39     INFO -  1305 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | initial mozImageSmoothingEnabled is true
22:53:39     INFO -  1306 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | mozImageSmoothingEnabled is false after setting
22:53:39     INFO -  1307 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | mozImageSmoothingEnabled is true after restore
22:53:39     INFO -  1308 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel is ({0:0, 1:255, 2:0, 3:255}) (expected [0,255,0,255])
22:53:39     INFO -  1309 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | c.width not 0
22:53:39     INFO -  1310 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | c.height not 0
22:53:39     INFO -  1311 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | isTransparentBlack
22:53:39     INFO -  1312 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | not the same length
22:53:39     INFO -  1313 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | changing dimensions broke canvas
22:53:39     INFO -  1314 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | initial dash offset is not 0
22:53:39     INFO -  1315 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | dash pattern [15, 10] is wrong
22:53:39     INFO -  1316 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | dash offset is wrong
22:53:39     INFO -  1317 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | dash pattern [5, 10, 15] is wrong
22:53:39     INFO -  1318 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | dash pattern ['1', 2] is wrong
22:53:39     INFO -  1319 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | dash offset is wrong
22:53:39     INFO -  1320 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 25,10 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1321 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 35,10 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1322 INFO dumping last 1 message(s)
22:53:39     INFO -  1323 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1324 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 40,25 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1325 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 40,35 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1326 INFO dumping last 1 message(s)
22:53:39     INFO -  1327 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1328 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 25,40 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1329 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 15,40 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1330 INFO dumping last 1 message(s)
22:53:39     INFO -  1331 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1332 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 10,25 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1333 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 10,15 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1334 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 55,10 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1335 INFO dumping last 1 message(s)
22:53:39     INFO -  1336 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1337 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 65,10 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1338 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 80,15 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1339 INFO dumping last 1 message(s)
22:53:39     INFO -  1340 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1341 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 80,25 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1342 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 75,40 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1343 INFO dumping last 1 message(s)
22:53:39     INFO -  1344 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1345 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 65,40 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1346 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 50,35 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1347 INFO dumping last 1 message(s)
22:53:39     INFO -  1348 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1349 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 50,25 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1350 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 95,10 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1351 INFO dumping last 1 message(s)
22:53:39     INFO -  1352 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1353 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 105,10 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1354 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 120,15 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1355 INFO dumping last 1 message(s)
22:53:39     INFO -  1356 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1357 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 120,25 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1358 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 115,40 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
22:53:39     INFO -  TEST-INFO | expected PASS
22:53:39     INFO -  1359 INFO dumping last 1 message(s)
22:53:39     INFO -  1360 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:39     INFO -  1361 INFO TEST-PASS | /tests/dom/canvas/test/test_canvas.html | pixel 105,40 of c687 is 0,255,0,255; expected 0,255,0,255 +/- 0
22:53:39     INFO -  1362 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/test_canvas.html | pixel 90,35 of c687 is 0,255,0,255; expected 0,0,0,0 +/- 0
This (or a very similar problem) is still happening with 

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:33.0) Gecko/20100101 Firefox/33.0

Firefox 33.1.1 from DMG from website, on a freshly installed OS/X 10.10.1 Yosemite

I'm getting it in the system.log during normal web browsing.  If someone thinks it's based on a different cause, let me know, and I will open a separate bug for it.

===

Nov 24 17:22:13 Jays-MacBook-Pro.local firefox[621]: CGContextTranslateCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

Nov 24 17:22:13 Jays-MacBook-Pro.local firefox[621]: CGContextScaleCTM: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

Nov 24 17:22:13 Jays-MacBook-Pro.local firefox[621]: CGContextSetInterpolationQuality: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
(This bug was the #1 ghit on a search for the relevant error message string)
So... what is the action in this bug?  Taking care of all the CGContext... messages from comment 0?  Or taking care of the unexpected fails in the tests from comment 1?  Or taking care of the messages from the tests that passed (e.g., "Nonzero value at position 2...")?
Have you been able to reproduce these warnings? Do you know under which conditions they appear?

So your patch protects two different kinds of contexts from being accessed when null: The main DrawTargetCG mCg, and the temporary UnboundednessFixer CGLayer mCg. For the former, I'd prefer if we'd just return false from DrawTargetCG::Init when mCg is null, so that the Factory just returns null instead of a broken DrawTarget. For the latter, we could just return baseCg from the fixer - this just means that the output will be slightly wrong (because the stuff around the draw bounds won't be affected), but only in the case where we failed doing the right thing. Jeff asked for a similar thing in bug 951443 comment 2. Though in that case returning baseCg meant that the result would still be correct...
Comment on attachment 8529236 [details] [diff] [review]
Check if the CG context is valid before calling methods on it.

Let me look at these suggestions.
Attachment #8529236 - Flags: review?(mstange)
Assignee: nobody → milan
Non withstanding changing the code so that we can't run into invalid contexts, adding some error messages if that does happen (bug 1101685 adds the asserts as well.)  We can then see if this still happens and take Markus' suggestion to fix the code so that it doesn't.
Attachment #8529236 - Attachment is obsolete: true
Attachment #8535799 - Flags: review?(mstange)
Comment on attachment 8535799 [details] [diff] [review]
Assert and annotate crash report if we run into invalid contexts. Also check for empty path before asking for a current point. r=mstange

Review of attachment 8535799 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really sure what the mCg checks are achieving. mCg is initialized in DrawTargetCG::Init and never changed from that point on. Wouldn't it be enough to check mCg at the end of DrawTargetCG::Init (only if Init returns true)? Or are you trying to protect against callers that call DrawTargetCG functions without having called Init on it?
Not really trying to protect at this point, trying to get more information as to what happens on Cedar, given that I don't see it locally.
Comment on attachment 8535799 [details] [diff] [review]
Assert and annotate crash report if we run into invalid contexts. Also check for empty path before asking for a current point. r=mstange

Review of attachment 8535799 [details] [diff] [review]:
-----------------------------------------------------------------

Okay then.
Attachment #8535799 - Flags: review?(mstange) → review+
Part of this run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f04a366bfe8f

Let's leave this open after this patch, as we're really trying to see what happens on Cedar and if it can point us to the underlying problem.
Keywords: checkin-needed, leave-open
For the record (re comment 2): autoupdate to 34.0.5 on 10.10.1 seems to have cleared up *my* version of this error message problem, at least.  Thanks to whomever did the work.  Leaving CC.
Phil, can you check if the original problem still happens?
Flags: needinfo?(philringnalda)
No, I can't. Releng got bored with running 10.9 on Cedar with absolutely nobody looking at fixing the failures seen there, so they gave up, we aren't ever going to run tests on 10.9, and they are starting in on 10.10 instead, but they haven't yet gotten far enough along to have tests actually running yet.
Flags: needinfo?(philringnalda)
OK, let's see what happens in 10.10
There is one place where DrawTargetCG::Init fails in this run. However, there are no complaints about us attempting to use it, so maybe we just close this one for now.

(In reply to Markus Stange [:mstange] from comment #10)
> ... Wouldn't it be
> enough to check mCg at the end of DrawTargetCG::Init (only if Init returns
> true)?

I didn't open a bug for this, but it's a valid suggestion.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: