946101 - [email] ActiveSync "Day to sync" appears to have not been saved if you do not completely exit settings after changing the setting on an account (it does get saved, but the ephemeral object view does not get updated)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

This can be reproduced in both V1.2 and V1.3

STR:
1. Configure an activesync email account
2. Go to Mail Settings
3. Tap on the email account set up at step 1
4. Change "Days to sync" to a different item
5. Tap on "<" to return to previous page. DO NOT click Done.
6. Tap on the email account again
   --> "Days to sync" displays previous setting. But if you click Done at step 5 and then check, the changes are made successfully.

Video for STR: https://mozilla.box.com/s/x4hd5tyw1f4e8mxr3xpo

buri V1.2 build
Gaia:     075e60c878b0eca68fba9e00bc85cb6eac03578a                         
Gecko:                                                                     
http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e         
BuildID   20131202004001                                                   
Version   26.0                                                             
ro.build.version.incremental=eng.archermind.20131114.105818  

buri V1.3 build
Gaia:     df070d4eed244e782dd3a7c2a7586d0741eac09f                         
Gecko:    http://hg.mozilla.org/mozilla-central/rev/9ac7ed427cd2           
BuildID   20131203151100                                                   
Version   28.0a1                                                           
ro.build.version.incremental=eng.zxliu.20131101.143946

Comment 2

[mkruml]

Occurs in Open_C 1.4

1.4 Environmental Variables:
Device: Open_C 1.4 MOZ
BuildID: 20140505000201
Gaia: fccb15d6940db51615545574877a62d69406b1c2
Gecko: bf937fbec8c1
Version: 30.0
Firmware Version: p821a10-eng_20140410

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Please add permafail here.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Attachment: update syncRange, add test coverage

A paper-cut a day extremely slowly decreases the number of outstanding bugs on a daily basis.

Comment 7

[James Burke [:jrburke]]

Comment on attachment 8517510 [details] [review]
update syncRange, add test coverage

r+ on inspection.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

landed:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/349
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/879a1f002ea2054fe09cb53497946152314d382e

https://github.com/mozilla-b2g/gaia/pull/25903
https://github.com/mozilla-b2g/gaia/commit/af328fe5cbd9244f0b5f4ae21788be56e1dc8697

Comment 9

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a926116946f8
Build-ID        20141111160205
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

[Result]
PASS